Skip to content

Commit 03c19b6

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Annotate some GWT-incompatible classes as @GwtIncompatible.
RELNOTES=n/a PiperOrigin-RevId: 785960288
1 parent 87976cd commit 03c19b6

File tree

10 files changed

+20
-2
lines changed

10 files changed

+20
-2
lines changed

android/guava/src/com/google/common/util/concurrent/ClosingFuture.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import static java.util.logging.Level.SEVERE;
3838
import static java.util.logging.Level.WARNING;
3939

40+
import com.google.common.annotations.GwtIncompatible;
4041
import com.google.common.annotations.J2ktIncompatible;
4142
import com.google.common.annotations.VisibleForTesting;
4243
import com.google.common.collect.FluentIterable;
@@ -190,7 +191,7 @@
190191
// TODO(dpb): Consider reusing one CloseableList for the entire pipeline, modulo combinations.
191192
@DoNotMock("Use ClosingFuture.from(Futures.immediate*Future)")
192193
@J2ktIncompatible
193-
// TODO(dpb): GWT compatibility.
194+
@GwtIncompatible // TODO(dpb): GWT compatibility.
194195
public final class ClosingFuture<V extends @Nullable Object> {
195196

196197
private static final LazyLogger logger = new LazyLogger(ClosingFuture.class);

android/guava/src/com/google/common/util/concurrent/ExecutionSequencer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static com.google.common.util.concurrent.MoreExecutors.directExecutor;
2626
import static java.util.Objects.requireNonNull;
2727

28+
import com.google.common.annotations.GwtIncompatible;
2829
import com.google.common.annotations.J2ktIncompatible;
2930
import com.google.errorprone.annotations.concurrent.LazyInit;
3031
import java.util.concurrent.Callable;
@@ -86,6 +87,7 @@
8687
* @since 26.0
8788
*/
8889
@J2ktIncompatible
90+
@GwtIncompatible
8991
public final class ExecutionSequencer {
9092

9193
private ExecutionSequencer() {}

android/guava/src/com/google/common/util/concurrent/ForwardingCondition.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@
1414

1515
package com.google.common.util.concurrent;
1616

17+
import com.google.common.annotations.GwtIncompatible;
1718
import com.google.common.annotations.J2ktIncompatible;
1819
import java.util.Date;
1920
import java.util.concurrent.TimeUnit;
2021
import java.util.concurrent.locks.Condition;
2122

2223
/** Forwarding wrapper around a {@code Condition}. */
2324
@J2ktIncompatible
25+
@GwtIncompatible
2426
abstract class ForwardingCondition implements Condition {
2527
abstract Condition delegate();
2628

android/guava/src/com/google/common/util/concurrent/ForwardingLock.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@
1414

1515
package com.google.common.util.concurrent;
1616

17+
import com.google.common.annotations.GwtIncompatible;
1718
import com.google.common.annotations.J2ktIncompatible;
1819
import java.util.concurrent.TimeUnit;
1920
import java.util.concurrent.locks.Condition;
2021
import java.util.concurrent.locks.Lock;
2122

2223
/** Forwarding wrapper around a {@code Lock}. */
2324
@J2ktIncompatible
25+
@GwtIncompatible
2426
abstract class ForwardingLock implements Lock {
2527
abstract Lock delegate();
2628

android/guava/src/com/google/common/util/concurrent/OverflowAvoidingLockSupport.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import static java.lang.Math.min;
1818

19+
import com.google.common.annotations.GwtIncompatible;
1920
import com.google.common.annotations.J2ktIncompatible;
2021
import java.util.concurrent.locks.LockSupport;
2122
import org.jspecify.annotations.Nullable;
@@ -25,6 +26,7 @@
2526
* signal on 32 bit devices running Android Q.
2627
*/
2728
@J2ktIncompatible
29+
@GwtIncompatible
2830
final class OverflowAvoidingLockSupport {
2931
// Represents the max nanoseconds representable on a linux timespec with a 32 bit tv_sec
3032
static final long MAX_NANOSECONDS_THRESHOLD = (1L + Integer.MAX_VALUE) * 1_000_000_000L - 1L;

guava/src/com/google/common/util/concurrent/ClosingFuture.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import static java.util.logging.Level.SEVERE;
3838
import static java.util.logging.Level.WARNING;
3939

40+
import com.google.common.annotations.GwtIncompatible;
4041
import com.google.common.annotations.J2ktIncompatible;
4142
import com.google.common.annotations.VisibleForTesting;
4243
import com.google.common.collect.FluentIterable;
@@ -190,7 +191,7 @@
190191
// TODO(dpb): Consider reusing one CloseableList for the entire pipeline, modulo combinations.
191192
@DoNotMock("Use ClosingFuture.from(Futures.immediate*Future)")
192193
@J2ktIncompatible
193-
// TODO(dpb): GWT compatibility.
194+
@GwtIncompatible // TODO(dpb): GWT compatibility.
194195
public final class ClosingFuture<V extends @Nullable Object> {
195196

196197
private static final LazyLogger logger = new LazyLogger(ClosingFuture.class);

guava/src/com/google/common/util/concurrent/ExecutionSequencer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static com.google.common.util.concurrent.MoreExecutors.directExecutor;
2626
import static java.util.Objects.requireNonNull;
2727

28+
import com.google.common.annotations.GwtIncompatible;
2829
import com.google.common.annotations.J2ktIncompatible;
2930
import com.google.errorprone.annotations.concurrent.LazyInit;
3031
import java.util.concurrent.Callable;
@@ -86,6 +87,7 @@
8687
* @since 26.0
8788
*/
8889
@J2ktIncompatible
90+
@GwtIncompatible
8991
public final class ExecutionSequencer {
9092

9193
private ExecutionSequencer() {}

guava/src/com/google/common/util/concurrent/ForwardingCondition.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@
1414

1515
package com.google.common.util.concurrent;
1616

17+
import com.google.common.annotations.GwtIncompatible;
1718
import com.google.common.annotations.J2ktIncompatible;
1819
import java.util.Date;
1920
import java.util.concurrent.TimeUnit;
2021
import java.util.concurrent.locks.Condition;
2122

2223
/** Forwarding wrapper around a {@code Condition}. */
2324
@J2ktIncompatible
25+
@GwtIncompatible
2426
abstract class ForwardingCondition implements Condition {
2527
abstract Condition delegate();
2628

guava/src/com/google/common/util/concurrent/ForwardingLock.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@
1414

1515
package com.google.common.util.concurrent;
1616

17+
import com.google.common.annotations.GwtIncompatible;
1718
import com.google.common.annotations.J2ktIncompatible;
1819
import java.util.concurrent.TimeUnit;
1920
import java.util.concurrent.locks.Condition;
2021
import java.util.concurrent.locks.Lock;
2122

2223
/** Forwarding wrapper around a {@code Lock}. */
2324
@J2ktIncompatible
25+
@GwtIncompatible
2426
abstract class ForwardingLock implements Lock {
2527
abstract Lock delegate();
2628

guava/src/com/google/common/util/concurrent/OverflowAvoidingLockSupport.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import static java.lang.Math.min;
1818

19+
import com.google.common.annotations.GwtIncompatible;
1920
import com.google.common.annotations.J2ktIncompatible;
2021
import java.util.concurrent.locks.LockSupport;
2122
import org.jspecify.annotations.Nullable;
@@ -25,6 +26,7 @@
2526
* signal on 32 bit devices running Android Q.
2627
*/
2728
@J2ktIncompatible
29+
@GwtIncompatible
2830
final class OverflowAvoidingLockSupport {
2931
// Represents the max nanoseconds representable on a linux timespec with a 32 bit tv_sec
3032
static final long MAX_NANOSECONDS_THRESHOLD = (1L + Integer.MAX_VALUE) * 1_000_000_000L - 1L;

0 commit comments

Comments
 (0)