Skip to content

Commit 4c4f855

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Remove deps on truth-java8-extension.
Its classes [have been part of the core Truth artifact since 1.4.2](google/truth#746 (comment)). Since we now depend on only one Truth artifact, I also inlined our `truth.version` property. Exception: I kept it in Guava, since we share it across multiple `pom.xml` files. (We _could_ accomplish the same thing by using `dependencyManagement` there, but [we have recently avoided it](https://github.com/google/guava/blob/257bc194f6e5bedd02115693f7416a84c3e4ba25/pom.xml#L107-L111), and I have some reservations around it, anyway, since it may override a newer version from a dependency. Fortunately, that is mostly academic now that we have Dependabot set up for almost all our projects.) The other thing about Guava is that we do _not_ have Dependabot set up for it. By keeping the version in a property, we allow our lesser Dependabot substitute, `versions-maven-plugin`, to bump it, as discussed on cl/554548816. RELNOTES=n/a PiperOrigin-RevId: 808216999
1 parent 257bc19 commit 4c4f855

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

guava-gwt/pom.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,6 @@
8888
</exclusion>
8989
</exclusions>
9090
</dependency>
91-
<dependency>
92-
<groupId>com.google.truth.extensions</groupId>
93-
<artifactId>truth-java8-extension</artifactId>
94-
<version>${truth.version}</version>
95-
<classifier>gwt</classifier>
96-
<scope>test</scope>
97-
<exclusions>
98-
<exclusion>
99-
<!-- use the guava we're building. -->
100-
<groupId>com.google.guava</groupId>
101-
<artifactId>guava</artifactId>
102-
</exclusion>
103-
</exclusions>
104-
</dependency>
10591
</dependencies>
10692
<repositories>
10793
<repository>

guava-tests/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,6 @@
4747
<version>${truth.version}</version>
4848
<scope>test</scope>
4949
</dependency>
50-
<dependency>
51-
<groupId>com.google.truth.extensions</groupId>
52-
<artifactId>truth-java8-extension</artifactId>
53-
<version>${truth.version}</version>
54-
<scope>test</scope>
55-
</dependency>
5650
<dependency>
5751
<groupId>com.google.jimfs</groupId>
5852
<artifactId>jimfs</artifactId>

0 commit comments

Comments
 (0)