From 4c4f855e85ee2aa5a0ee8c5a91de19a8153f3e0e Mon Sep 17 00:00:00 2001 From: cpovirk Date: Wed, 17 Sep 2025 10:47:49 -0700 Subject: [PATCH] Remove deps on `truth-java8-extension`. Its classes [have been part of the core Truth artifact since 1.4.2](https://github.com/google/truth/issues/746#issuecomment-1972041135). Since we now depend on only one Truth artifact, I also inlined our `truth.version` property. Exception: I kept it in Guava, since we share it across multiple `pom.xml` files. (We _could_ accomplish the same thing by using `dependencyManagement` there, but [we have recently avoided it](https://github.com/google/guava/blob/257bc194f6e5bedd02115693f7416a84c3e4ba25/pom.xml#L107-L111), and I have some reservations around it, anyway, since it may override a newer version from a dependency. Fortunately, that is mostly academic now that we have Dependabot set up for almost all our projects.) The other thing about Guava is that we do _not_ have Dependabot set up for it. By keeping the version in a property, we allow our lesser Dependabot substitute, `versions-maven-plugin`, to bump it, as discussed on cl/554548816. RELNOTES=n/a PiperOrigin-RevId: 808216999 --- guava-gwt/pom.xml | 14 -------------- guava-tests/pom.xml | 6 ------ 2 files changed, 20 deletions(-) diff --git a/guava-gwt/pom.xml b/guava-gwt/pom.xml index e734323c48a6..30e398409f23 100644 --- a/guava-gwt/pom.xml +++ b/guava-gwt/pom.xml @@ -88,20 +88,6 @@ - - com.google.truth.extensions - truth-java8-extension - ${truth.version} - gwt - test - - - - com.google.guava - guava - - - diff --git a/guava-tests/pom.xml b/guava-tests/pom.xml index b7fe0d5aaf5d..c56b0e48378b 100644 --- a/guava-tests/pom.xml +++ b/guava-tests/pom.xml @@ -47,12 +47,6 @@ ${truth.version} test - - com.google.truth.extensions - truth-java8-extension - ${truth.version} - test - com.google.jimfs jimfs