Remove unused outputChan (#691)

Author: msuozzo

pkg/build/gcb/executor.go

@@ -107,7 +107,6 @@ func (e *Executor) Start(ctx context.Context, input rebuild.Input, opts build.Op
 		id:           buildID,
 		executor:     e,
 		output:       pipe,
-		outputChan:   make(chan string, 100),
 		resultChan:   make(chan build.Result, 1),
 		cancelPolicy: opts.CancelPolicy,
 		status:       build.BuildStateStarting,
@@ -166,7 +165,6 @@ func (e *Executor) Close(ctx context.Context) error {
 
 // executeBuild runs the actual build process using Cloud Build
 func (e *Executor) executeBuild(ctx context.Context, handle *gcbHandle, cloudBuild *cloudbuild.Build, input rebuild.Input, opts build.Options, plan *Plan) {
-	defer close(handle.outputChan)
 	// Construct BuildInfo to be incrementally set.
 	buildInfo := rebuild.BuildInfo{
 		Target:      input.Target,

pkg/build/gcb/handle.go

@@ -18,7 +18,6 @@ type gcbHandle struct {
 	executor     *Executor
 	operation    *cloudbuild.Operation
 	output       io.ReadWriteCloser // BufferedPipe for streaming output
-	outputChan   chan string
 	resultChan   chan build.Result
 	cancelPolicy build.CancelPolicy
 

pkg/build/gcb/handle_test.go

@@ -37,7 +37,6 @@ func TestGCBHandle(t *testing.T) {
 		id:           "test-build-123",
 		executor:     executor,
 		output:       pipe,
-		outputChan:   make(chan string, 100),
 		resultChan:   make(chan build.Result, 1),
 		cancelPolicy: build.CancelImmediate,
 		status:       build.BuildStateStarting,
@@ -120,7 +119,6 @@ func TestGCBHandleWait(t *testing.T) {
 		id:           "test-build-123",
 		executor:     executor,
 		output:       pipe,
-		outputChan:   make(chan string, 100),
 		resultChan:   make(chan build.Result, 1),
 		cancelPolicy: build.CancelImmediate,
 		status:       build.BuildStateStarting,
@@ -161,7 +159,6 @@ func TestGCBHandleWaitSuccess(t *testing.T) {
 		id:           "test-build-123",
 		executor:     executor,
 		output:       pipe,
-		outputChan:   make(chan string, 100),
 		resultChan:   make(chan build.Result, 1),
 		cancelPolicy: build.CancelImmediate,
 		status:       build.BuildStateStarting,
@@ -222,7 +219,6 @@ func TestGCBHandleCancelPolicies(t *testing.T) {
 				executor:     executor,
 				operation:    operation,
 				output:       pipe,
-				outputChan:   make(chan string, 100),
 				resultChan:   make(chan build.Result, 1),
 				cancelPolicy: tc.cancelPolicy,
 				status:       build.BuildStateRunning,