fix(vulnfeeds): empty affected ranges being added (#3981)

Author: jess-lowe

vulnfeeds/cmd/debian/main.go

@@ -140,7 +140,10 @@ func generateOSVFromDebianTracker(debianData DebianSecurityTrackerData, debianRe
 				if release.Status == "resolved" {
 					pkgInfo.VersionInfo.AffectedVersions = []models.AffectedVersion{{Fixed: release.FixedVersion}}
 				}
-				v.AddPkgInfo(pkgInfo)
+
+				if len(pkgInfo.VersionInfo.AffectedVersions) > 0 {
+					v.AddPkgInfo(pkgInfo)
+				}
 			}
 		}
 	}

vulnfeeds/cmd/debian/main_test.go

@@ -75,31 +75,14 @@ func TestGenerateOSVFromDebianTracker(t *testing.T) {
 		"trixie":   "13",
 	}
 	cveStuff := map[cves.CVEID]cves.Vulnerability{
-		"CVE-2014-1424":    loadTestData(t, "CVE-2014-1424"),
-		"CVE-2017-6507":    loadTestData(t, "CVE-2017-6507"),
-		"CVE-2018-1000500": loadTestData(t, "CVE-2018-1000500"),
-		"CVE-2016-1585":    loadTestData(t, "CVE-2016-1585"),
+		"CVE-2014-1424": loadTestData(t, "CVE-2014-1424"),
+		"CVE-2017-6507": loadTestData(t, "CVE-2017-6507"),
+		"CVE-2016-1585": loadTestData(t, "CVE-2016-1585"),
 	}
 	got := generateOSVFromDebianTracker(trackerData, releaseMap, cveStuff)
 
 	// Define the expected OSV entries.
 	want := map[string]*vulns.Vulnerability{
-		"CVE-2018-1000500": {
-			Vulnerability: osvschema.Vulnerability{
-				ID:        "DEBIAN-CVE-2018-1000500",
-				Upstream:  []string{"CVE-2018-1000500"},
-				Modified:  now,
-				Published: now,
-				Details:   "Busybox contains a Missing SSL certificate validation vulnerability in The \"busybox wget\" applet that can result in arbitrary code execution. This attack appear to be exploitable via Simply download any file over HTTPS using \"busybox wget https://compromised-domain.com/important-file\".",
-				Affected: []osvschema.Affected{
-					{Package: osvschema.Package{Name: "busybox", Ecosystem: "Debian:10"}, EcosystemSpecific: map[string]any{"urgency": "end-of-life"}},
-					{Package: osvschema.Package{Name: "busybox", Ecosystem: "Debian:11"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
-					{Package: osvschema.Package{Name: "busybox", Ecosystem: "Debian:12"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
-					{Package: osvschema.Package{Name: "busybox", Ecosystem: "Debian:13"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
-				},
-				References: []osvschema.Reference{{Type: "ADVISORY", URL: "https://security-tracker.debian.org/tracker/CVE-2018-1000500"}},
-			},
-		},
 		"CVE-2014-1424": {
 			Vulnerability: osvschema.Vulnerability{
 				ID:         "DEBIAN-CVE-2014-1424",
@@ -119,9 +102,6 @@ func TestGenerateOSVFromDebianTracker(t *testing.T) {
 				Published: now,
 				Details:   "In all versions of AppArmor mount rules are accidentally widened when compiled.",
 				Affected: []osvschema.Affected{
-					{Package: osvschema.Package{Name: "apparmor", Ecosystem: "Debian:10"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
-					{Package: osvschema.Package{Name: "apparmor", Ecosystem: "Debian:11"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
-					{Package: osvschema.Package{Name: "apparmor", Ecosystem: "Debian:12"}, EcosystemSpecific: map[string]any{"urgency": "unimportant"}},
 					{
 						Package:           osvschema.Package{Name: "apparmor", Ecosystem: "Debian:13"},
 						Ranges:            []osvschema.Range{{Type: "ECOSYSTEM", Events: []osvschema.Event{{Introduced: "0"}, {Fixed: "3.0.12-1"}}}},

vulnfeeds/test_data/debian/debian_security_tracker_mock.json

@@ -1,47 +1,4 @@
 {
-  "busybox": {
-    "CVE-2018-1000500": {
-      "description": "Busybox contains a Missing SSL certificate validation vulnerability in The \"busybox wget\" applet that can result in arbitrary code execution. This attack appear to be exploitable via Simply download any file over HTTPS using \"busybox wget https://compromised-domain.com/important-file\".",
-      "scope": "local",
-      "releases": {
-        "bookworm": {
-          "status": "open",
-          "repositories": {
-            "bookworm": "1:1.35.0-4"
-          },
-          "urgency": "unimportant"
-        },
-        "bullseye": {
-          "status": "open",
-          "repositories": {
-            "bullseye": "1:1.30.1-6"
-          },
-          "urgency": "unimportant"
-        },
-        "buster": {
-          "status": "open",
-          "repositories": {
-            "buster": "1:1.30.1-4"
-          },
-          "urgency": "end-of-life"
-        },
-        "sid": {
-          "status": "open",
-          "repositories": {
-            "sid": "1:1.36.1-6"
-          },
-          "urgency": "unimportant"
-        },
-        "trixie": {
-          "status": "open",
-          "repositories": {
-            "trixie": "1:1.36.1-6"
-          },
-          "urgency": "unimportant"
-        }
-      }
-    }
-  },
   "apparmor": {
     "CVE-2014-1424": {
       "description": "apparmor_parser in the apparmor package before 2.8.95~2430-0ubuntu5.1 in Ubuntu 14.04 allows attackers to bypass AppArmor policies via unspecified vectors, related to a \"miscompilation flaw.\"",