Skip to content

Commit 3ede3bf

Browse files
authored
Revert "ui: seperating the display and generation of Wattson warnings (#3012)" (#3027)
Reason: Two-fold: 1) Wattson is not enough of a "core Perfetto feature" that we need to have the tracks show up on every trace type. For example, right now, this will show up on Linux traces, heap profiles heap dumps etc. Unconditionally showing tracks when you have no data is not OK: the user may have very intentially not enabled your stuff, warning them every time and using valuable real estate is unacceptable. If we want something like this, we should add something to a section on the info and stats page but even then, we need to scope it to "if the person expected Wattson to be enabled": if they don't care about it, it should not bother them 2) I tried on a random trace and the warnings just appeared broken. If I clicked on the warning, nothing showed up. This reverts commit f98fd0e.
1 parent f98fd0e commit 3ede3bf

File tree

60 files changed

+149
-187
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+149
-187
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ae976a3a0fb8f645262a4c2839d54b68f19bd02aea4a8963294341fea5004582
1+
8e7dcea756612f6e3ae6c359f328e3dbebe12500705d39a4905fa83ffd65678e
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3838c10e2a0ceac26d687d6d097b3d5f50a10daa7bcce7143b229aac746acd73
1+
c099751bf51ebc06e854313213a9aa2311e36dbee3fadf4aaa3ffe5e8a76c6de
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0614b9acfc0eecddeafbc5df1a19265fa9d582c112e9ee65b2c1ba6b330f8c3c
1+
383b972f8ad528d12d3436399cd775a1300d10a7b4949235d9443299cb2d733d
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3838c10e2a0ceac26d687d6d097b3d5f50a10daa7bcce7143b229aac746acd73
1+
c099751bf51ebc06e854313213a9aa2311e36dbee3fadf4aaa3ffe5e8a76c6de
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3838c10e2a0ceac26d687d6d097b3d5f50a10daa7bcce7143b229aac746acd73
1+
c099751bf51ebc06e854313213a9aa2311e36dbee3fadf4aaa3ffe5e8a76c6de
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3838c10e2a0ceac26d687d6d097b3d5f50a10daa7bcce7143b229aac746acd73
1+
c099751bf51ebc06e854313213a9aa2311e36dbee3fadf4aaa3ffe5e8a76c6de
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7c7c7eac611b869ca8aba8fe49b1b504c8d018f99e4c76ccda6b401608f6c701
1+
1f50705991e2df02678ef5195fb75b5531de232ef0ffc97f733b731fcc31d2fd
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
62852ec76940a4217c7b7951c0c739c96cd10689766c454680def12db241df6e
1+
13a3ca8e7c92b5db375f6b8d84bbf213bc4ae6db2849c29bb8c5e5a40d3e2c17
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f9ac6431e4abf390045b6cf3ac8bc504509b2a42073f36f1d0d5b1ee2d687dd0
1+
06ecfa1b019293dad99c690fb4d8c15db594e9be339c04332c529a27f4fc1fb6
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8b58eef519220204106ceb4b9ac43ee11d5d1f9042856a1047b074a5a0d81c84
1+
026e942d66212572afaffe070ec740b58f44ebebd6f7eac5f0322137eddb7408

0 commit comments

Comments
 (0)