Skip to content

Crashes inside query flamegraph when selecting slices / areas #3836

@altimin

Description

@altimin

I've been seeing a lot of random crashes in the flamegraph code, triggered when selecting slices / small areas. It hasn't been consistent, but pretty frequent, probably there is a race condition somewhere.

Failed assertion
 -  (Error: Failed assertion)
 - assertTrue (src/base/logging.ts:62:4)
 - assertFalse (src/base/logging.ts:67:2)
 - SharedAsyncDisposable.clone (src/base/shared_disposable.ts:112:4)
 - Object.work (src/components/query_flamegraph.ts:235:8)
 - AsyncLimiter.runTaskQueue (src/base/async_limiter.ts:65:10)
 - AsyncLimiter.schedule (src/base/async_limiter.ts:51:6)
 - QueryFlamegraph.fetchData (src/components/query_flamegraph.ts:226:4)
 - QueryFlamegraph.render (src/components/query_flamegraph.ts:203:8)
 - Object.render (src/plugins/dev.perfetto.TraceProcessorTrack/index.ts:561:10)
 -  (src/frontend/timeline_page/current_selection_tab.ts:112:7)

Trace: not available (FILE). Provide repro steps.
UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/142.0.0.0 Safari/537.36
Referrer: https://github.com/google/perfetto/pull/3831

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions