Merge pull request #124 from google/Fix-pickle-jar-tag-observer

Fixed a bug caused by not using a deep copy with an observer

Author: incident-recipient

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>com.google.pdsl</groupId>
     <artifactId>pdsl</artifactId>
-    <version>1.7.9-SNAPSHOT</version>
+    <version>1.7.10-SNAPSHOT</version>
 
     <name>pdsl</name>
     <url>http://www.github.com/google/polymorphicDSL</url>

src/main/java/com/pdsl/gherkin/PickleJarFactory.java

@@ -127,11 +127,15 @@ private List<PickleJar.PickleJarScenario> convertScenariosToPickleJarScenarios(L
                         if (table.getTags().isPresent()) {
                             tableTags.addAll(processTags(table.getTags().get()));
                         }
-                        builder.withTags(processTags(tableTags));
+                        // Use a deep copy.
+                        // Otherwise if the observer adds additional tags to the set they
+                        // will be added for ALL of the tabular scenarios
+                        Set<String> potentiallyMutatedTags = new HashSet<>(tableTags);
                         // notifying observers
                         notifyObservers(
                             scenario.getTitle().orElseThrow().getStringWithSubstitutions(substitutions),
-                            substitutedSteps, tableTags, substitutions);
+                            substitutedSteps, potentiallyMutatedTags, substitutions);
+                        builder.withTags(processTags(potentiallyMutatedTags));
                         pickleJarScenarios.add(builder.build());
                     }
                 }