Modified test files to reflect new filtering rules

Author: nboyer-google

src/main/java/com/pdsl/gherkin/executors/GherkinTestExecutor.java

@@ -28,6 +28,7 @@
 import java.net.URI;
 import java.nio.charset.StandardCharsets;
 import java.util.Collection;
+import java.util.List;
 import java.util.Optional;
 import java.util.Set;
 
@@ -41,7 +42,7 @@ public class GherkinTestExecutor implements TraceableTestRunExecutor {
     private final GherkinTestSpecificationFactory testSpecificationFactory;
     private final TestCaseFactory testCaseFactory = new PreorderTestCaseFactory();
     private final Logger logger = LoggerFactory.getLogger(GherkinTestExecutor.class);
-    private final TraceableTestRunExecutor executor = new DefaultPolymorphicDslTestExecutor();
+    private final TraceableTestRunExecutor executor = DefaultPolymorphicDslTestExecutor.of(List.of());
 
     public <SG extends Parser, SL extends Lexer> GherkinTestExecutor(Class<SG> subgrammarParser, Class<SL> subgrammarLexer) {
         phraseFilter = new DefaultPolymorphicDslPhraseFilter(subgrammarParser, subgrammarLexer);

src/main/java/com/pdsl/gherkin/models/GherkinFeature.java

@@ -71,10 +71,8 @@ public static class Builder {
         private List<GherkinScenario> gherkinScenarios = new ArrayList<>();
         private List<GherkinRule> rules = new ArrayList<>();
         private Optional<List<String>> tags = Optional.empty();
-        private int lineNumber = -1;
-        private int linePosition = -1;
 
-				private static final String LOCATION_ERROR = "Location cannot be null!";
+        private static final String LOCATION_ERROR = "Location cannot be null!";
         public Builder(URI location) {
 
             Preconditions.checkArgument(location == null, LOCATION_ERROR);
@@ -98,16 +96,6 @@ public GherkinFeature build() {
             return new GherkinFeature(this);
         }
 
-        public Builder withLineNumber(int lineNumber) {
-            this.lineNumber = lineNumber;
-            return this;
-        }
-
-        public Builder withLinePosition(int linePosition) {
-            this.linePosition = linePosition;
-            return this;
-        }
-
         public Builder addScenario(GherkinScenario scenario) {
             gherkinScenarios.add(scenario);
             return this;

src/test/java/com/pdsl/api/GherkinPolymorphicDslTestExecutor.java

@@ -65,6 +65,9 @@ public void minimalFeature_runsAllTests()  {
         assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the minimalism inside a background");
         assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the minimalism");
 
+        assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the minimalism inside a background");
+        assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the minimalism");
+
         assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the minimalism inside a background");
         assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given a rule background step");
         assertThat(stepCounterListener.getStepsInOrderRun().poll().strip()).isEqualTo("Given the 1 minimalism");

src/test/java/com/pdsl/api/PolymorphicDslGherkinExecution.java

@@ -184,6 +184,9 @@ public void gherkinTestSpecification_executesComplexBackgroundFeatureProperly()
         assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the minimalism inside a background");
         assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the minimalism");
 
+        assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the minimalism inside a background");
+        assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the minimalism");
+
         assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the minimalism inside a background");
         assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given a rule background step");
         assertThat(stepCounterListener.getStepsInOrderRun().poll()).contains("Given the 1 minimalism");

src/test/java/com/pdsl/component/FrameworkTestCase.java

@@ -87,9 +87,7 @@ public void longFeatureFiles_haveLineNumbersMappedToScenarios() throws URISyntax
                 AllGrammarsLexer.class,
                 "polymorphicDslAllRules"
         );
-        GherkinTestExecutor gherkinTestExecutor = new GherkinTestExecutor(phraseFilter,
-                // Disable printing because file is too long
-                DefaultPolymorphicDslTestExecutor.ofWithoutDuplicateFiltering(List.of()));
+        GherkinTestExecutor gherkinTestExecutor = new GherkinTestExecutor(phraseFilter);
         // Act
 
         MetadataTestRunResults results = gherkinTestExecutor.runTestsWithMetadata(dslFiles, new TestCaseFactoryParserListenerImpl(), "Component");