-
Notifications
You must be signed in to change notification settings - Fork 152
Open
Description
I'm getting error building the library in Envoy:
@@com_github_google_quiche//:quic_core_connection_alarms_lib which I believe the source i
ERROR: /external/com_github_google_quiche/BUILD.bazel:2317:22: Compiling quiche/quic/core/quic_connection_alarms.cc failed: (Exit 1): cc_wrapper.sh failed: error executing CppCompile command (from target @@com_github_google_quiche//:quic_core_connection_alarms_lib) external/local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics ... (remaining 203 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.cc:5:
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:41:32: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
41 | virtual QuicConnectionContext* context() = 0;
| ^
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:41:32: note: insert '_Nullable' if the pointer may be null
41 | virtual QuicConnectionContext* context() = 0;
| ^
| _Nullable
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:41:32: note: insert '_Nonnull' if the pointer should never be null
41 | virtual QuicConnectionContext* context() = 0;
| ^
| _Nonnull
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:129:31: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
129 | QuicConnectionAlarmsDelegate* delegate() { return connection_; }
| ^
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:129:31: note: insert '_Nullable' if the pointer may be null
129 | QuicConnectionAlarmsDelegate* delegate() { return connection_; }
| ^
| _Nullable
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:129:31: note: insert '_Nonnull' if the pointer should never be null
129 | QuicConnectionAlarmsDelegate* delegate() { return connection_; }
| ^
| _Nonnull
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:168:31: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
168 | QuicConnectionAlarmsDelegate* connection_;
| ^
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:168:31: note: insert '_Nullable' if the pointer may be null
168 | QuicConnectionAlarmsDelegate* connection_;
| ^
| _Nullable
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:168:31: note: insert '_Nonnull' if the pointer should never be null
168 | QuicConnectionAlarmsDelegate* connection_;
| ^
| _Nonnull
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:184:38: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
184 | QuicAlarmProxy(QuicAlarmMultiplexer* multiplexer, QuicAlarmSlot slot)
| ^
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:184:38: note: insert '_Nullable' if the pointer may be null
184 | QuicAlarmProxy(QuicAlarmMultiplexer* multiplexer, QuicAlarmSlot slot)
| ^
| _Nullable
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:184:38: note: insert '_Nonnull' if the pointer should never be null
184 | QuicAlarmProxy(QuicAlarmMultiplexer* multiplexer, QuicAlarmSlot slot)
| ^
| _Nonnull
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:204:23: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
204 | QuicAlarmMultiplexer* multiplexer_;
| ^
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:204:23: note: insert '_Nullable' if the pointer may be null
204 | QuicAlarmMultiplexer* multiplexer_;
| ^
| _Nullable
external/com_github_google_quiche/quiche/quic/core/quic_connection_alarms.h:204:23: note: insert '_Nonnull' if the pointer should never be null
204 | QuicAlarmMultiplexer* multiplexer_;
| ^
| _Nonnull
5 errors generated.
Target //test/extensions/filters/http/on_demand:on_demand_filter_test failed to build
Here is a try to fix https://github.com/google/quiche/pull/94/files
Metadata
Metadata
Assignees
Labels
No labels