Merge pull request #119 from google/all-type-log-export-update

update create data export for all log types

Author: mihirvala-crestdata

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.19.1] - 2025-09-19
+### Fixed
+- Create data export for all log types flag
+
 ## [0.19.0] - 2025-09-18
 ### Added
 - Support for export native dashboard method

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "secops"
-version = "0.19.0"
+version = "0.19.1"
 description = "Python SDK for wrapping the Google SecOps API for common use cases"
 readme = "README.md"
 requires-python = ">=3.7"

src/secops/chronicle/data_export.py

@@ -199,7 +199,15 @@ def create_data_export(
 
     # Add export_all_logs if True
     if export_all_logs:
-        payload["export_all_logs"] = True
+        # Setting log type as ALL TYPES for all log export
+        payload["log_type"] = (
+            f"projects/{client.project_id}/"
+            f"locations/{client.region}/instances/"
+            f"{client.customer_id}/logTypes/ALL_TYPES"
+        )
+        # export_all_logs parameter is currently not valid
+        # TODO: Revert back to export_all_logs once parameter works
+        # payload["export_all_logs"] = True
 
     # Construct the URL and send the request
     url = f"{client.base_url}/{client.instance_id}/dataExports"

tests/chronicle/test_data_export.py

@@ -173,9 +173,8 @@ def test_create_data_export_with_all_logs(chronicle_client):
 
         # Check that the request payload included export_all_logs
         mock_post.assert_called_once()
-        args, kwargs = mock_post.call_args
-        assert kwargs["json"]["export_all_logs"] is True
-        assert "log_type" not in kwargs["json"]
+        _, kwargs = mock_post.call_args
+        assert "ALL_TYPES" in kwargs["json"]["log_type"]
 
 
 def test_cancel_data_export(chronicle_client):