ChronicleClient.replace_data_table_rows possibly writes only the last chunk of rows

[nazarii-plebanskyi-rf]

Hello, it seems like ChronicleClient.replace_data_table_rows method might write only the last chunk of rows.

It calls dataTableRows:bulkReplace method for each chunk of rows and each call replaces already existing rows (as per documentation).
So, eventually only the last chunk of rows exists in the data table.

NOTE: I haven't tested the function, it's just something I noticed in the implementation.

[mihirvala-crestdata]

Thank you for pointing this out. It will indeed only replace last chunk of rows.

I'll update to create request in payload for each chunk of rows, so that all chunked rows can be replaced rather than last one.

[nazarii-plebanskyi-rf]

@mihirvala-crestdata so the first chunk would be called with dataTableRows:bulkReplace and remaining ones would be called with dataTableRows.bulkCreate?

[mihirvala-crestdata]

I conveyed it bit wrong, I think. As per dataTableRows:bulkReplace doc, It accepts list of CreateDataTableRows requests.

So I meant, we can update current implementation of ChronicleClient.replace_data_table_rows to create list of request with each chunk of rows. That way all rows can be replaced with dataTableRows:bulkReplace itself. No need to call dataTableRows.bulkCreate I guess.

[nazarii-plebanskyi-rf]

oh, so you can do the same for create_data_table_rows method as well.