Skip to content

Commit 6a70548

Browse files
kjlubickSkCQ
authored andcommitted
Pin all rust crates
Cargo's versioning [1] automatically allows patch updates and this has caused unintentional issues in the past when Cargo/Bazel quietly update things [2][3]. By applying the =prefix, it means "exactly that version". This pins all rust crates and updates cxxbridge to match cxx, which is probably a good idea as those two packages are related. The package bytemuck was already updated under the hood to 1.23.2, so I pinned it there (plus v1.16.0 had been yanked/unreleased) [1] https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html [2] https://skia-review.googlesource.com/c/skia/+/1043196/comments/dbb481d9_007491a9 [3] https://skia-review.googlesource.com/c/skia/+/1028717 Change-Id: I7931161d0ad15f8bd99a97919e8ad5e45643da75 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1045116 Auto-Submit: Kaylee Lubick <[email protected]> Commit-Queue: Eric Boren <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Reviewed-by: Eric Boren <[email protected]> Reviewed-by: Daniel Dilan <[email protected]> Commit-Queue: Daniel Dilan <[email protected]>
1 parent 8c7cf4c commit 6a70548

File tree

2 files changed

+208
-144
lines changed

2 files changed

+208
-144
lines changed

MODULE.bazel

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,12 @@ crate = use_extension("@rules_rust//crate_universe:extensions.bzl", "crate")
9898
crate.spec(
9999
features = ["derive"],
100100
package = "bytemuck",
101-
version = "1.16.0",
101+
version = "=1.23.2",
102102
)
103103
crate.spec(
104104
# If this is updated, be sure to update BUILD.gn also
105105
package = "cxx",
106-
version = "1.0.168",
106+
version = "=1.0.168",
107107
)
108108
crate.annotation(
109109
# We want a custom build rule so we can use a different include path
@@ -116,7 +116,7 @@ crate.annotation(
116116
)
117117
crate.spec(
118118
package = "font-types",
119-
version = "0.9",
119+
version = "=0.9",
120120
)
121121
crate.spec(
122122
features = [
@@ -138,27 +138,27 @@ crate.spec(
138138
"msl-out",
139139
],
140140
package = "naga",
141-
version = "0.20.0",
141+
version = "=0.20.0",
142142
)
143143
crate.spec(
144144
package = "peniko",
145-
version = "0.1.1",
145+
version = "=0.1.1",
146146
)
147147
crate.spec(
148148
package = "read-fonts",
149-
version = "0.32",
149+
version = "=0.32",
150150
)
151151
crate.spec(
152152
package = "regex",
153-
version = "1.8.1",
153+
version = "=1.11.1",
154154
)
155155
crate.spec(
156156
package = "skrifa",
157-
version = "0.34",
157+
version = "=0.34",
158158
)
159159
crate.spec(
160160
package = "thiserror",
161-
version = "1.0.60",
161+
version = "=1.0.69",
162162
)
163163
crate.from_specs(
164164
# by default, intel macs are not included in this list, but we have CI hardware
@@ -182,7 +182,7 @@ cargo_bindeps = use_extension("@rules_rust//crate_universe:extension.bzl", "crat
182182
cargo_bindeps.spec(
183183
artifact = "bin",
184184
package = "cxxbridge-cmd",
185-
version = "1.0.158",
185+
version = "=1.0.168",
186186
)
187187
cargo_bindeps.annotation(
188188
crate = "cxxbridge-cmd",

0 commit comments

Comments
 (0)