Skip to content

Commit 50efbbf

Browse files
authored
Disambiguate a resolve message (#458)
I had a duplicate kwargs named 'disabled'. This ended up with a message 'keyword argument disabled repeated', which is really difficult to parse. Hope to clarify things by changing that text a bit.
1 parent c52844e commit 50efbbf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

resolve/resolve.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ func (r *resolver) expr(e syntax.Expr) {
746746
}
747747
x := binop.X.(*syntax.Ident)
748748
if seenName[x.Name] {
749-
r.errorf(x.NamePos, "keyword argument %s repeated", x.Name)
749+
r.errorf(x.NamePos, "keyword argument %q is repeated", x.Name)
750750
} else {
751751
if seenName == nil {
752752
seenName = make(map[string]bool)

resolve/testdata/resolve.star

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ U = 1 # ok (legacy)
340340
---
341341
# https://github.com/bazelbuild/starlark/starlark/issues/21
342342
def f(**kwargs): pass
343-
f(a=1, a=1) ### `keyword argument a repeated`
343+
f(a=1, a=1) ### `keyword argument "a" is repeated`
344344

345345

346346
---

0 commit comments

Comments
 (0)