Skip to content

xls_dslx_generate_cpp_type_files does not actually support deps #3045

@mikex-oss

Description

@mikex-oss

Describe the bug
If the target DSLX src file depend on types (not constants) from its deps, the generated C++ will be invalid.

You will get error: use of undeclared identifier '<type defined in dependency>'.

Expected behavior
There should be a mechanism to include generated headers from dependencies.

Additional context
Related: #1610 would expose this problem more heavily. To date, we've limited the impact of this bug because commonly its constants from DSLX dependencies that are referenced. These are just turned into literals in the generated C++.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupTech debt reduction, factoring, consolidation, rework, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions