Skip to content

Commit d5e2539

Browse files
authored
feat(mc2mc): unset additional hints (#89)
feat: unset additional hints
1 parent 37b260b commit d5e2539

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

mc2mc/internal/client/odps.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,17 @@ func (c *odpsClient) terminate(instance *odps.Instance) error {
180180

181181
func addHints(additionalHints map[string]string, query string) map[string]string {
182182
hints := make(map[string]string)
183-
for k, v := range additionalHints {
184-
hints[k] = v
185-
}
186183
multisql := strings.Contains(query, ";")
187184
if multisql {
188185
hints["odps.sql.submit.mode"] = "script"
189186
}
187+
for k, v := range additionalHints {
188+
if _, ok := hints[k]; ok && v == "" {
189+
delete(hints, k) // remove empty hints
190+
continue
191+
}
192+
hints[k] = v
193+
}
190194

191195
return hints
192196
}

0 commit comments

Comments
 (0)