api calls hanging (#186)

* #178 Fix API calls hangs by checking Tls12 support or enforce Tls12 depending of the target:
- net40 : check that (SecurityProtocolType)3072 is specified
- net45 : check that SecurityProtocolType.Tls12 is specified
- net46 : check that SecurityProtocolType.Tls12 is specified
- net47 (target added) : check that SecurityProtocolType.Tls12 or SecurityProtocolType.UseDefault is specified
- net471 (target added) : force usage of Tls12 in HttpClient ctor
- netstandard1.3 : force usage of Tls12 in HttpClient ctor
- netstandard2.0 : force usage of Tls12 in HttpClient ctor

* #178 Update documentation about Tls 1.2 requirements

Author: gpailler

MegaApiClient.Tests/Context/TestContext.cs

@@ -2,9 +2,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Net.Http;
-using System.Threading;
-using System.Threading.Tasks;
 using Xunit.Abstractions;
 
 namespace CG.Web.MegaApiClient.Tests.Context
@@ -57,7 +54,7 @@ public void ClearLogger()
     protected virtual IMegaApiClient CreateClient()
     {
       Options = new Options(applicationKey: "ewZQFBBC");
-      WebClient = new TestWebClient(new WebClient(WebTimeout, null, new TestMessageHandler(), false), MaxRetry, _logMessageAction);
+      WebClient = new TestWebClient(new WebClient(WebTimeout, null, false), MaxRetry, _logMessageAction);
 
       return new MegaApiClient(Options, WebClient);
     }
@@ -83,13 +80,5 @@ private void OnApiRequestFailed(object _, ApiRequestFailedEventArgs e)
     {
       _logMessageAction($"ApiRequestFailed: {e.ApiResult}, {e.ApiUrl}, {e.AttemptNum}, {e.RetryDelay}, {e.ResponseJson}, {e.Exception} {e.Exception?.Message}");
     }
-
-    private class TestMessageHandler : HttpClientHandler
-    {
-      protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
-      {
-        return await base.SendAsync(request, cancellationToken);
-      }
-    }
   }
 }

MegaApiClient/MegaApiClient.csproj

@@ -31,33 +31,33 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <TargetFrameworks>net40;net45;net46;netstandard1.3;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net40;net45;net46;net47;net471;netstandard1.3;netstandard2.0</TargetFrameworks>
     <RootNamespace>CG.Web.MegaApiClient</RootNamespace>
     <SignAssembly>False</SignAssembly>
     <DocumentationFile>bin\docs\MegaApiClient.xml</DocumentationFile>
     <NoWarn>1591</NoWarn>
   </PropertyGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'net40' Or '$(TargetFramework)' == 'net45' Or '$(TargetFramework)' == 'net46'">
+  <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard')) == 'false'">
     <Reference Include="System" />
     <Reference Include="System.Web" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'net45' Or '$(TargetFramework)' == 'net46'">
+  <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard')) == 'false' And $(TargetFramework) != 'net40'">
     <Reference Include="System.Net.Http" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3' Or '$(TargetFramework)' == 'netstandard2.0'">
+  <ItemGroup Condition="$(TargetFramework.StartsWith('netstandard')) == 'true'">
     <PackageReference Include="System.Net.Http">
       <Version>4.3.4</Version>
     </PackageReference>
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
+  <ItemGroup Condition="$(TargetFramework) == 'netstandard1.3'">
     <PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="1.1.2" />
   </ItemGroup>
 
-  <PropertyGroup Condition="'$(TargetFramework)' == 'net40' Or '$(TargetFramework)' == 'net45' Or '$(TargetFramework)' == 'net46'">
+  <PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard')) == 'false'">
     <SignAssembly>True</SignAssembly>
     <AssemblyOriginatorKeyFile>../key.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
@@ -78,7 +78,7 @@
     <SourceRoot Include="$(MSBuildThisFileDirectory)/" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
       <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+      <IncludeAssets>runtime;build;native;contentfiles;analyzers</IncludeAssets>
     </PackageReference>
   </ItemGroup>
 

MegaApiClient/WebClient_HttpClient.cs

@@ -7,6 +7,7 @@ namespace CG.Web.MegaApiClient
   using System.Reflection;
   using System.Text;
   using System.Threading;
+  using System.Security.Authentication;
 
   using System.Net.Http;
   using System.Net.Http.Headers;
@@ -18,14 +19,30 @@ public class WebClient : IWebClient
     private readonly HttpClient _httpClient;
 
     public WebClient(int responseTimeout = DefaultResponseTimeout, ProductInfoHeaderValue userAgent = null)
-      : this(responseTimeout, userAgent, null, false)
+      : this(responseTimeout, userAgent, false)
     {
     }
 
-    internal WebClient(int responseTimeout, ProductInfoHeaderValue userAgent, HttpMessageHandler messageHandler, bool connectionClose)
+    internal WebClient(int responseTimeout, ProductInfoHeaderValue userAgent, bool connectionClose)
     {
       BufferSize = Options.DefaultBufferSize;
-      _httpClient = messageHandler == null ? new HttpClient() : new HttpClient(messageHandler);
+#if NET471 || NETSTANDARD
+      _httpClient = new HttpClient(new HttpClientHandler { SslProtocols = SslProtocols.Tls12 }, true);
+#elif NET47
+      if (!ServicePointManager.SecurityProtocol.HasFlag(SecurityProtocolType.Tls12) && !ServicePointManager.SecurityProtocol.HasFlag(SecurityProtocolType.SystemDefault))
+      {
+        throw new NotSupportedException("mega.nz API requires support for TLS v1.2 or higher. Check https://gpailler.github.io/MegaApiClient/#compatibility for additional information");
+      }
+
+      _httpClient = new HttpClient();
+#else
+      if (!ServicePointManager.SecurityProtocol.HasFlag(SecurityProtocolType.Tls12))
+      {
+        throw new NotSupportedException("mega.nz API requires support for TLS v1.2 or higher. Check https://gpailler.github.io/MegaApiClient/#compatibility for additional information");
+      }
+
+      _httpClient = new HttpClient();
+#endif
       _httpClient.Timeout = TimeSpan.FromMilliseconds(responseTimeout);
       _httpClient.DefaultRequestHeaders.UserAgent.Add(userAgent ?? GenerateUserAgent());
       _httpClient.DefaultRequestHeaders.ConnectionClose = connectionClose;

MegaApiClient/WebClient_HttpWebRequest.cs

@@ -17,6 +17,11 @@ public class WebClient : IWebClient
 
     public WebClient(int responseTimeout = DefaultResponseTimeout, string userAgent = null)
     {
+      if (!ServicePointManager.SecurityProtocol.HasFlag((SecurityProtocolType)3072))
+      {
+        throw new NotSupportedException("mega.nz API requires support for TLS v1.2 or higher. Check https://gpailler.github.io/MegaApiClient/#compatibility for additional information");
+      }
+
       BufferSize = Options.DefaultBufferSize;
       _responseTimeout = responseTimeout;
       _userAgent = userAgent ?? GenerateUserAgent();

docs/index.md

@@ -14,26 +14,28 @@ Getting started with MegaApiClient
 
 #### Compatibility
 
-The library supports .NET 4.0, .NET 4.5, .NET 4.6 and [.NET Standard 1.3](https://docs.microsoft.com/en-us/dotnet/standard/net-standard). Here is the list of all supported implementations:
+The library is built for the following targets: .NET 4.0, .NET 4.5, .NET 4.6, .NET 4.7, .NET 4.7.1, .NET Standard 1.3 and .NET Standard 2.0.
+Here is the list of all supported implementations:
 
 | Implementation             | Version   |
 |----------------------------|-----------|
 | .NET Framework             | 4.0       |
 | .NET Framework             | >= 4.5    |
-| .NET Core                  | >= 1.0    |
+| .NET Core / .NET           | >= 1.0    |
 | Mono                       | >= 4.6    |
 | Xamarin.iOS                | >= 10.0   |
 | Xamarin.Mac                | >= 3.0    |
 | Xamarin.Android            | >= 7.0    |
 | Universal Windows Platform | >= 10.0   |
 | Unity*                     | >= 2018.2 |
 
-⚠️ TLS 1.2 support should be configured explicitely when using .NET Framework <= 4.5 or  all the API calls to Mega will hang.
-- For .NET Framework 4.5, add `ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;`
+---
+⚠️ TLS 1.2 support should be enforced when using .NET Framework <= 4.7 or all the API calls to Mega will hang.
+- For .NET Framework from 4.5 to 4.7.0, add `ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;`
 - For .NET Framework 4, add `ServicePointManager.SecurityProtocol = (SecurityProtocolType)3072;` (.NET 4.5 should be installed on the machine).
+- Alternatively, you can add relevant switches in your app.config https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls  
 
 ---
-
 \* Need a link.xml file if IL2CPP is used:
 ```
 <linker>
@@ -44,7 +46,6 @@ The library supports .NET 4.0, .NET 4.5, .NET 4.6 and [.NET Standard 1.3](https:
     </assembly>
 </linker>
 ```
-
 ---
 
 MegaApiClient source is available on [GitHub](https://github.com/gpailler/MegaApiClient) and is released under [MIT](https://choosealicense.com/licenses/mit/) license.