Set TerminationMessagePolicy on Initializer to use logs as fallback

While not explicitly used, with the removal of the log fetching from the
Initializer (Job->Pod->Container) any potential source for verbose information
about the error might be lost. The Kubernetes approach to provide more details
than the exit code about the reason a container terminated is the termination
message (see [1]).

Per default this message needs to be explictly written to `/dev/termination-log`,
but there also is the option to use the last bit of log output as fallback source.

[1] https://kubernetes.io/docs/tasks/debug/debug-application/determine-reason-pod-failure/

Author: frittentheke

pkg/resources/jobs/initializer.go

@@ -114,16 +114,17 @@ func NewInitializerJob(k6 v1alpha1.TestRunI, argLine string) (*batchv1.Job, erro
 					InitContainers:               getInitContainers(k6.GetSpec().Initializer, script),
 					Containers: []corev1.Container{
 						{
-							Image:           image,
-							ImagePullPolicy: k6.GetSpec().Initializer.ImagePullPolicy,
-							Name:            "k6",
-							Command:         command,
-							Env:             env,
-							Resources:       k6.GetSpec().Initializer.Resources,
-							VolumeMounts:    volumeMounts,
-							EnvFrom:         k6.GetSpec().Initializer.EnvFrom,
-							Ports:           ports,
-							SecurityContext: &k6.GetSpec().Initializer.ContainerSecurityContext,
+							Image:                    image,
+							ImagePullPolicy:          k6.GetSpec().Initializer.ImagePullPolicy,
+							Name:                     "k6",
+							Command:                  command,
+							Env:                      env,
+							Resources:                k6.GetSpec().Initializer.Resources,
+							VolumeMounts:             volumeMounts,
+							EnvFrom:                  k6.GetSpec().Initializer.EnvFrom,
+							Ports:                    ports,
+							SecurityContext:          &k6.GetSpec().Initializer.ContainerSecurityContext,
+							TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 						},
 					},
 					Volumes: volumes,

pkg/resources/jobs/initializer_test.go

@@ -93,10 +93,11 @@ func TestNewInitializerJob(t *testing.T) {
 									},
 								},
 							},
-							Resources:       corev1.ResourceRequirements{},
-							VolumeMounts:    script.VolumeMount(),
-							Ports:           []corev1.ContainerPort{{ContainerPort: 6565}},
-							SecurityContext: &corev1.SecurityContext{},
+							Resources:                corev1.ResourceRequirements{},
+							VolumeMounts:             volumeMounts,
+							Ports:                    []corev1.ContainerPort{{ContainerPort: 6565}},
+							SecurityContext:          &corev1.SecurityContext{},
+							TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 						},
 					},
 					Volumes: volumes,