What's the best way to aggregate on duration?

[psirenny]

Hey @benjie!

Our team is trying to add support for aggregating on durations with an interval data type but noticed that's not supported by the library yet. Is it straightforward to add that support? If so, we can take a stab at implementing it and submit PR. Alternatively, we could switch to representing durations with float instead if you recommend that.

[benjie]

V4 or V5?

[psirenny]

Sorry, I should have mentioned that it's on V5.

[benjie]

Weirdly... we already have interval in the codebase:

pg-aggregates/src/AggregateSpecsPlugin.ts

Line 92 in 975eefb

[INTERVAL_OID]: TYPES.interval, // interval -> interval

I think the isNumberLike detection is too narrow:

pg-aggregates/src/AggregateSpecsPlugin.ts

Line 75 in 975eefb

isSuitableType: isNumberLike,

/

pg-aggregates/src/AggregateSpecsPlugin.ts

Lines 30 to 35 in 975eefb

	if (pgType.typcategory === "N") {
	if (!pgCodec.extensions) {
	pgCodec.extensions = Object.create(null);
	}
	pgCodec.extensions!.isNumberLike = true;
	}

.

Looks like it should be relatively straightforward to fix this; just expand to isNumberLike || isIntervalLike (or similar).

[psirenny]

Copy that! We'll submit a PR to add support.