feat: improved ChangePermissions message handling in the subgraph

Author: juanmardefago

packages/subgraph/schema.graphql

@@ -52,6 +52,7 @@ type ChangePermissionsMessage implements Message @entity {
   block: MessageBlock!
   data: Bytes
   address: String!
+  validThrough: BigInt!
   oldPermissions: [String!]!
   newPermissions: [String!]!
 }

packages/subgraph/src/mapping.ts

@@ -592,13 +592,20 @@ function executeChangePermissionsMessage(
   let message = cache.getChangePermissionsMessage(id);
   let address = reader.advance(20).toHexString(); // address should always be 20 bytes
 
+  // Get valid_through
+  let validThrough = decodeU64(reader) as i32;
+  if (!reader.ok) {
+    return;
+  }
+
   // Get the length of the new premissions list
   let permissionsListLength = decodeU64(reader) as i32;
   if (!reader.ok) {
     return;
   }
 
   let permissionEntry = cache.getPermissionListEntry(address);
+  permissionEntry.validThrough = BigInt.fromI32(validThrough)
   let oldPermissionList = permissionEntry.permissions;
   let newPermissionList = new Array<String>();
 
@@ -609,17 +616,20 @@ function executeChangePermissionsMessage(
 
   message.block = messageBlock.id;
   message.address = address;
+  message.validThrough = validThrough;
   message.oldPermissions = oldPermissionList;
   message.newPermissions = newPermissionList;
   message.data = reader.diff(snapshot);
 
 
   let list = globalState.permissionList;
-  list.push(permissionEntry.id);
+  if(!list.includes(permissionEntry.id)) {
+    list.push(permissionEntry.id);
+  } else if (permissionsListLength == 0) {
+    // this will remove the now empty permission entry from the list, preventing spam
+    list.splice(list.indexOf(permissionEntry.id), 1)
+  }
   globalState.permissionList = list;
-
-  // might want to remove it from the "allow list" if the new permission list length is 0
-  // Right now the address won't be able to execute anything on that case, but it can spam
 }
 
 function executeResetStateMessage(

packages/subgraph/src/store-cache.ts

@@ -94,11 +94,13 @@ export class StoreCache {
 
   getPermissionListEntry(id: String): PermissionListEntry {
     if (this.permissionListEntries.safeGet(id) == null) {
-      let permissionListyEntry = PermissionListEntry.load(id);
-      if (permissionListyEntry == null) {
-        permissionListyEntry = new PermissionListEntry(id);
+      let permissionListEntry = PermissionListEntry.load(id);
+      if (permissionListEntry == null) {
+        permissionListEntry = new PermissionListEntry(id);
+        permissionListEntry.permissions = [];
+        permissionListEntry.validThrough = BigInt.fromI32(0);
       }
-      this.permissionListEntries.set(id, permissionListyEntry);
+      this.permissionListEntries.set(id, permissionListEntry);
     }
     return this.permissionListEntries.safeGet(id)!;
   }