fix: handle NaN/Infinity in usage statistics percentage calculation (#7329)

Author: adambenhassen

packages/services/api/src/modules/schema/providers/breaking-schema-changes-helper.ts

@@ -37,14 +37,14 @@ export class BreakingSchemaChangeUsageHelper {
     return {
       topAffectedOperations: schemaChange.usageStatistics.topAffectedOperations.map(operation => {
         // Note:
-        // "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
-        // causing a zero devision and GraphQL exception,
-        // because we aggressively poll for the schema change after publishing usage data
-        // it seems like clickhouse slighty lags behind for the materialized view here.
-        // since it only happens in context of an integration test (no production issues)
-        // we can safely treat 0 as 1 request.
-        const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
-        const percentage = (operation.count / totalRequestCount) * 100;
+        // "metadata.usage.totalRequestCount" is sometimes 0/NaN in integration tests
+        // due to ClickHouse eventual consistency lag.
+        // We ensure the percentage is always a finite number to avoid GraphQL serialization errors.
+        const totalRequestCount = Number.isFinite(metadata.usage.totalRequestCount)
+          ? Math.max(1, metadata.usage.totalRequestCount)
+          : 1;
+        const count = Number.isFinite(operation.count) ? operation.count : 0;
+        const percentage = (count / totalRequestCount) * 100;
         return {
           ...operation,
           percentage,
@@ -53,18 +53,18 @@ export class BreakingSchemaChangeUsageHelper {
       }),
       topAffectedClients: schemaChange.usageStatistics.topAffectedClients.map(client => {
         // Note:
-        // "metadata.usage.totalRequestCount" is sometimes 0 in case of a integration test
-        // causing a zero devision and GraphQL exception,
-        // because we aggressively poll for the schema change after publishing usage data
-        // it seems like clickhouse slighty lags behind for the materialized view here.
-        // since it only happens in context of an integration test (no production issues)
-        // we can safely treat 0 as 1 request.
-        const totalRequestCount = Math.max(1, metadata.usage.totalRequestCount);
-        const percentage = (client.count / totalRequestCount) * 100;
+        // "metadata.usage.totalRequestCount" is sometimes 0/NaN in integration tests
+        // due to ClickHouse eventual consistency lag.
+        // We ensure the percentage is always a finite number to avoid GraphQL serialization errors.
+        const totalRequestCount = Number.isFinite(metadata.usage.totalRequestCount)
+          ? Math.max(1, metadata.usage.totalRequestCount)
+          : 1;
+        const count = Number.isFinite(client.count) ? client.count : 0;
+        const percentage = (count / totalRequestCount) * 100;
 
         return {
           ...client,
-          countFormatted: formatNumber(client.count),
+          countFormatted: formatNumber(count),
           percentage,
           percentageFormatted: formatPercentage(percentage),
         };