Fix Leak Tests on Node 25 & Run Stitching & Router tests in parallel (#1693)

Author: ardatan

.github/workflows/test.yml

@@ -24,7 +24,10 @@ jobs:
           - 22
           - 24
           - 25
-    name: Unit / Node v${{matrix.node-version}}
+        hive-router-runtime:
+          - 0
+          - 1
+    name: Unit / Node v${{matrix.node-version}} / ${{matrix.hive-router-runtime == 1 && 'Router' || 'Stitching'}} Runtime
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -33,12 +36,10 @@ jobs:
         uses: the-guild-org/shared-config/setup@v1
         with:
           node-version: ${{matrix.node-version}}
-      - name: Test with Stitching Runtime
+      - name: Test
         run: yarn test
-      - name: Test with Router Runtime
         env:
-          HIVE_ROUTER_RUNTIME: 1
-        run: yarn test
+          HIVE_ROUTER_RUNTIME: ${{matrix.hive-router-runtime}}
 
   unit-bun:
     name: Unit / Bun
@@ -74,7 +75,10 @@ jobs:
           - 22
           - 24
           - 25
-    name: Leaks / Node v${{matrix.node-version}}
+        hive-router-runtime:
+          - 0
+          - 1
+    name: Leaks / Node v${{matrix.node-version}} / ${{matrix.hive-router-runtime == 1 && 'Router' || 'Stitching'}} Runtime
     needs: [unit] # leak tests run unit tests but check for leaks; if unit tests fail, leaks will fail too - avoid confusion by running them in series
     runs-on: ubuntu-latest
     steps:
@@ -84,16 +88,10 @@ jobs:
         uses: the-guild-org/shared-config/setup@v1
         with:
           node-version: ${{matrix.node-version}}
-      - name: Test with Stitching Runtime
-        uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          command: yarn test:leaks
-      - name: Test with Router Runtime
+      - name: Test
         uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
         env:
-          HIVE_ROUTER_RUNTIME: 1
+          HIVE_ROUTER_RUNTIME: ${{matrix.hive-router-runtime}}
         with:
           timeout_minutes: 10
           max_attempts: 3

.yarn/patches/jest-environment-node-npm-30.2.0-b72db4433a.patch

@@ -0,0 +1,27 @@
+diff --git a/build/index.js b/build/index.js
+index 866ad663d0f392c721c39cbcb3be88d19b85fac2..ebd7d6ac7a6793d5dadf848ace3db05e4837d976 100644
+--- a/build/index.js
++++ b/build/index.js
+@@ -61,9 +61,19 @@ function _jestValidate() {
+  */
+ 
+ // some globals we do not want, either because deprecated or we set it ourselves
+-const denyList = new Set(['GLOBAL', 'root', 'global', 'globalThis', 'Buffer', 'ArrayBuffer', 'Uint8Array',
+-// if env is loaded within a jest test
+-'jest-symbol-do-not-touch']);
++const denyList = new Set([
++  "GLOBAL",
++  "root",
++  "global",
++  "globalThis",
++  "Buffer",
++  "ArrayBuffer",
++  "Uint8Array",
++  // if env is loaded within a jest test
++  "jest-symbol-do-not-touch",
++  // Causing `SecurityError: Cannot initialize local storage without a `--localstorage-file` path`
++  "localStorage"
++]);
+ const nodeGlobals = new Map(Object.getOwnPropertyNames(globalThis).filter(global => !denyList.has(global)).map(nodeGlobalsKey => {
+   const descriptor = Object.getOwnPropertyDescriptor(globalThis, nodeGlobalsKey);
+   if (!descriptor) {

package.json

@@ -76,6 +76,7 @@
     "esbuild": "0.25.5",
     "graphql": "16.12.0",
     "ioredis-mock": "patch:[email protected]#~/.yarn/patches/ioredis-mock-npm-8.9.0-530d4422b9.patch",
+    "jest-environment-node@npm:30.2.0": "patch:jest-environment-node@npm%3A30.2.0#~/.yarn/patches/jest-environment-node-npm-30.2.0-b72db4433a.patch",
     "jest-leak-detector": "patch:jest-leak-detector@npm:29.7.0#~/.yarn/patches/jest-leak-detector+29.7.0.patch",
     "pkgroll": "patch:pkgroll@npm:2.5.1#~/.yarn/patches/pkgroll-npm-2.5.1-9b062c22ca.patch",
     "tar": "7.5.2",

yarn.lock

@@ -16570,6 +16570,21 @@ __metadata:
   languageName: node
   linkType: hard
 
+"jest-environment-node@patch:jest-environment-node@npm%3A30.2.0#~/.yarn/patches/jest-environment-node-npm-30.2.0-b72db4433a.patch":
+  version: 30.2.0
+  resolution: "jest-environment-node@patch:jest-environment-node@npm%3A30.2.0#~/.yarn/patches/jest-environment-node-npm-30.2.0-b72db4433a.patch::version=30.2.0&hash=e5d4cf"
+  dependencies:
+    "@jest/environment": "npm:30.2.0"
+    "@jest/fake-timers": "npm:30.2.0"
+    "@jest/types": "npm:30.2.0"
+    "@types/node": "npm:*"
+    jest-mock: "npm:30.2.0"
+    jest-util: "npm:30.2.0"
+    jest-validate: "npm:30.2.0"
+  checksum: 10c0/f380cff85bbd4d0d5cd56341670f696635a9abb73e1ef4ba21a23c14967b029a64c0dca80ff63d738d7b23d1087e35dc8e9322ccd5aab95e31e663c146ae8dee
+  languageName: node
+  linkType: hard
+
 "jest-get-type@npm:^29.6.3":
   version: 29.6.3
   resolution: "jest-get-type@npm:29.6.3"