-
Notifications
You must be signed in to change notification settings - Fork 13
feat: moved pin button (fix expanded state) to header #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e554911
feat: moved pin button to header
1f6c235
fix: subheader menu selection
0d6f30e
test: updated screenshots
7ac3077
feat: added case without logo
80ec2a0
test: updated screenshots with new left margin
b29859f
feat: get back title for compact button
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
Binary file modified
BIN
-286 Bytes
(99%)
...sual.test.tsx-snapshots/ActionBar-render-story-Showcase-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-299 Bytes
(99%)
...visual.test.tsx-snapshots/ActionBar-render-story-Showcase-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-294 Bytes
(99%)
...ual.test.tsx-snapshots/ActionBar-render-story-Showcase-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-309 Bytes
(99%)
...isual.test.tsx-snapshots/ActionBar-render-story-Showcase-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-286 Bytes
(99%)
...test.tsx-snapshots/ActionBar-render-story-SingleSection-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-299 Bytes
(99%)
...l.test.tsx-snapshots/ActionBar-render-story-SingleSection-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-294 Bytes
(99%)
...est.tsx-snapshots/ActionBar-render-story-SingleSection-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-309 Bytes
(99%)
....test.tsx-snapshots/ActionBar-render-story-SingleSection-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-285 Bytes
(99%)
....test.tsx-snapshots/ActionBar-render-story-StretchGroup-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-299 Bytes
(99%)
...al.test.tsx-snapshots/ActionBar-render-story-StretchGroup-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-294 Bytes
(99%)
...test.tsx-snapshots/ActionBar-render-story-StretchGroup-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-308 Bytes
(99%)
...l.test.tsx-snapshots/ActionBar-render-story-StretchGroup-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-340 Bytes
(99%)
...st.tsx-snapshots/AsideHeader-render-story-AdvancedUsage-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-350 Bytes
(99%)
...test.tsx-snapshots/AsideHeader-render-story-AdvancedUsage-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-342 Bytes
(99%)
...t.tsx-snapshots/AsideHeader-render-story-AdvancedUsage-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-363 Bytes
(99%)
...est.tsx-snapshots/AsideHeader-render-story-AdvancedUsage-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-46 Bytes
(100%)
...tsx-snapshots/AsideHeader-render-story-CustomBackground-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+48 Bytes
(100%)
...t.tsx-snapshots/AsideHeader-render-story-CustomBackground-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-104 Bytes
(100%)
...sx-snapshots/AsideHeader-render-story-CustomBackground-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+63 Bytes
(100%)
....tsx-snapshots/AsideHeader-render-story-CustomBackground-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+89 Bytes
(100%)
...test.tsx-snapshots/AsideHeader-render-story-CustomTheme-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+161 Bytes
(100%)
...l.test.tsx-snapshots/AsideHeader-render-story-CustomTheme-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+32 Bytes
(100%)
...est.tsx-snapshots/AsideHeader-render-story-CustomTheme-light-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+284 Bytes
(100%)
....test.tsx-snapshots/AsideHeader-render-story-CustomTheme-light-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+689 Bytes
(100%)
...test.tsx-snapshots/AsideHeader-render-story-HeaderAlert-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.17 KB
(100%)
...l.test.tsx-snapshots/AsideHeader-render-story-HeaderAlert-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.05 KB
(100%)
...est.tsx-snapshots/AsideHeader-render-story-HeaderAlert-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1018 Bytes
(100%)
....test.tsx-snapshots/AsideHeader-render-story-HeaderAlert-light-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-83 Bytes
(100%)
...-snapshots/AsideHeader-render-story-HeaderAlertCentered-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-273 Bytes
(100%)
...sx-snapshots/AsideHeader-render-story-HeaderAlertCentered-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
+205 Bytes
(100%)
...snapshots/AsideHeader-render-story-HeaderAlertCentered-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+170 Bytes
(100%)
...x-snapshots/AsideHeader-render-story-HeaderAlertCentered-light-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
+9 Bytes
(100%)
...sx-snapshots/AsideHeader-render-story-HeaderAlertCustom-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+50 Bytes
(100%)
....tsx-snapshots/AsideHeader-render-story-HeaderAlertCustom-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
...x-snapshots/AsideHeader-render-story-HeaderAlertCustom-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+84 Bytes
(100%)
...tsx-snapshots/AsideHeader-render-story-HeaderAlertCustom-light-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...l.test.tsx-snapshots/AsideHeader-render-story-LineClamp-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...ual.test.tsx-snapshots/AsideHeader-render-story-LineClamp-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
....test.tsx-snapshots/AsideHeader-render-story-LineClamp-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...al.test.tsx-snapshots/AsideHeader-render-story-LineClamp-light-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-287 Bytes
(100%)
....tsx-snapshots/AsideHeader-render-story-MultipleTooltip-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-261 Bytes
(100%)
...st.tsx-snapshots/AsideHeader-render-story-MultipleTooltip-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-283 Bytes
(100%)
...tsx-snapshots/AsideHeader-render-story-MultipleTooltip-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-319 Bytes
(100%)
...t.tsx-snapshots/AsideHeader-render-story-MultipleTooltip-light-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-38 Bytes
(100%)
...al.test.tsx-snapshots/AsideHeader-render-story-Showcase-dark-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+27 Bytes
(100%)
...sual.test.tsx-snapshots/AsideHeader-render-story-Showcase-dark-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-112 Bytes
(100%)
...l.test.tsx-snapshots/AsideHeader-render-story-Showcase-light-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+61 Bytes
(100%)
...ual.test.tsx-snapshots/AsideHeader-render-story-Showcase-light-webkit-linux.png
Oops, something went wrong.
40 changes: 1 addition & 39 deletions
40
src/components/AsideHeader/components/CollapseButton/CollapseButton.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,11 @@ | ||
| @use '../../../variables'; | ||
| @use '~@gravity-ui/uikit/styles/mixins'; | ||
|
|
||
| $block: '.#{variables.$ns}collapse-button'; | ||
|
|
||
| $buttonHeight: 20px; | ||
|
|
||
| #{$block} { | ||
| --_--focus-outline-color: var(--g-color-line-focus); | ||
| --_--focus-outline-offset: 0; | ||
|
|
||
| @include mixins.button-reset(); | ||
|
|
||
| min-height: $buttonHeight; | ||
| width: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| border-top: 1px solid | ||
| var(--gn-aside-header-divider-horizontal-color, var(--_--horizontal-divider-line-color)); | ||
| position: relative; | ||
| box-sizing: content-box; | ||
|
|
||
| &::before { | ||
| content: ''; | ||
| position: absolute; | ||
| z-index: -1; | ||
| inset: 0 2px 2px; | ||
| } | ||
|
|
||
| &:focus-visible::before { | ||
| outline: var(--_--focus-outline-color) solid 2px; | ||
| outline-offset: var(--_--focus-outline-offset); | ||
| } | ||
|
|
||
| &:not(&_compact) { | ||
| &_compact { | ||
| #{$block}__icon { | ||
| transform: rotate(180deg); | ||
| } | ||
| } | ||
|
|
||
| &:hover #{$block}__icon { | ||
| color: var(--g-color-text-primary); | ||
| } | ||
|
|
||
| &__icon { | ||
| color: var(--g-color-text-secondary); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.