Skip to content

Conversation

@robcresswell
Copy link

fixes: #2968

@robcresswell
Copy link
Author

robcresswell commented Nov 10, 2025

Note this would raise the minimum supported node version for this library to >=18.x

18 itself is already EOL, but typically Linux-based operating systems only carry very, very old versions of Node, so it might be problematic in some cases.

@robcresswell
Copy link
Author

@murgatroid99 before I burn a bunch of time figuring out how to test this on Windows, could you confirm those are unexpected failures? I can't see much helpful in the logs, but I'm also not sure what to look out for 🤓

@murgatroid99
Copy link
Member

Don't worry about those. They're irrelevant. The grpc-tools build jobs are the relevant ones here.

Also, can you bump the library's patch version?

@robcresswell
Copy link
Author

robcresswell commented Nov 13, 2025

@murgatroid99 I don't think there's a later version? https://www.npmjs.com/package/@mapbox/node-pre-gyp only goes to 2.0.0

I'd seen the 2.0.1 release on https://github.com/mapbox/node-pre-gyp which is what I'm assuming you're referring to, but it doesn't appear to be available on npm

@robcresswell
Copy link
Author

robcresswell commented Nov 13, 2025

The library maintainers seem to be unsure how they can solve their publishing woes from glancing through mapbox/node-pre-gyp#907

@robcresswell
Copy link
Author

robcresswell commented Nov 13, 2025

OH you meant the grpc-tools library version! Suddenly dawned on me while making coffee. Done.

@robcresswell robcresswell force-pushed the feat/update-node-pre-gyp branch from 27191d7 to 51b8020 Compare November 13, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please consider updating grpc-tools @mapbox/node-pre-gyp to something more resent

3 participants