use instance_double if possible

Author: e2

spec/lib/guard/rspec/command_spec.rb

@@ -35,7 +35,8 @@
 
       before do
         allow(RSpec::Core::ConfigurationOptions).to receive(:new) do
-          double(options: { formatters: formatters })
+          instance_double(RSpec::Core::ConfigurationOptions,
+                          options: { formatters: formatters })
         end
       end
 

spec/lib/guard/rspec/runner_spec.rb

@@ -7,9 +7,9 @@
 RSpec.describe Guard::RSpec::Runner do
   let(:options) { { cmd: "rspec" } }
   let(:runner) { Guard::RSpec::Runner.new(options) }
-  let(:inspector) { double(Guard::RSpec::Inspectors::SimpleInspector) }
-  let(:notifier) { double(Guard::RSpec::Notifier) }
-  let(:results) { double(Guard::RSpec::Results) }
+  let(:inspector) { instance_double(Guard::RSpec::Inspectors::SimpleInspector) }
+  let(:notifier) { instance_double(Guard::RSpec::Notifier) }
+  let(:results) { instance_double(Guard::RSpec::Results) }
 
   before do
     allow(Guard::Compat::UI).to receive(:info)
@@ -142,7 +142,6 @@
     let(:paths) { %w(spec_path1 spec_path2) }
     before do
       allow(inspector).to receive(:paths) { paths }
-      allow(inspector).to receive(:clear_paths) { true }
       allow(inspector).to receive(:failed)
     end
 

spec/lib/guard/rspec_spec.rb

@@ -5,7 +5,7 @@
   let(:default_options) { Guard::RSpec::Options::DEFAULTS }
   let(:options) { {} }
   let(:plugin) { Guard::RSpec.new(options) }
-  let(:runner) { double(Guard::RSpec::Runner) }
+  let(:runner) { instance_double(Guard::RSpec::Runner) }
 
   before do
     allow(Guard::Compat::UI).to receive(:info)

spec/spec_helper.rb

@@ -8,6 +8,14 @@
 rspec_version = ::RSpec::Version::STRING.to_f
 old_rspec = (rspec_version < 3)
 
+if old_rspec
+  class RSpec::Core::ExampleGroup
+    def instance_double(*args)
+      double(*args)
+    end
+  end
+end
+
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|