Skip to content

Conversation

@cwrm56
Copy link
Collaborator

@cwrm56 cwrm56 commented Nov 19, 2025

Summary by cubic

Adds support for admin and manager scopes for service accounts using client credentials, with fallback to fern-read when user info isn’t available. Also switches projectId auto-generation to UUIDs.

  • New Features
    • Check admin scopes first in RequireAuth, then manager, then fern-read.
    • Read admin/manager scopes from config and fetch token scopes via introspection.
    • Allow RequireAdmin with admin-scoped tokens; set service-account user with proper role and is_service_account=true.
    • Auto-generate UUID projectId in createProject; updated tests.

Written for commit 55423be. Summary will update automatically on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@cwrm56 cwrm56 changed the title Add fern-admin scope to allow client credentials admin rights feat: Add fern-admin scope to allow client credentials admin rights Nov 19, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 1 file (reviewed changes from recent commits).

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="deployments/fern-platform-kubevela.yaml">

<violation number="1" location="deployments/fern-platform-kubevela.yaml:766">
The image was changed to docker.io/library/fern-platform:latest even though the build only exists under ghcr.io/guidewire-oss or docker.io/guidewireoss; pointing at the library namespace makes the deployment fail because that image does not exist.</violation>

<violation number="2" location="deployments/fern-platform-kubevela.yaml:767">
Setting imagePullPolicy to Never prevents Kubernetes from pulling the remote fern-platform image, causing pods on fresh nodes to fail with ImagePullBackOff. Use Always or IfNotPresent for registry-hosted images.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@nimish22 nimish22 force-pushed the feature/support-admin-scope branch from b221d3a to a2c4dea Compare November 20, 2025 05:35
@nimish22 nimish22 changed the title feat: Add fern-admin scope to allow client credentials admin rights feature: add fern-admin scope to allow client credentials admin rights Nov 24, 2025
@nimish22 nimish22 changed the title feature: add fern-admin scope to allow client credentials admin rights feat: add fern-admin scope to allow client credentials admin rights Nov 24, 2025
@nimish22 nimish22 force-pushed the feature/support-admin-scope branch from a2c4dea to 55423be Compare November 24, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants