feat: support default file as .cjs #269
Open
+148,095
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace DEFAULTS `configFile` with `configFilename` - remove default config argument from cli commands - simplify `load` function to not catch errors - update `loadUserConfig` function to load a provided config path with no catch - update `loadUserConfig` function to attempt to load the default config path for both `js` and `cjs` extensions (ignoring `Cannot find` error type if thrown), falling back to default config if none found - yarn version explicitly set (allows project to work as intended in yarn v2+ environments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates happo.io to be able to load the default config filename with either a
cjsorjsextension.configFilewithconfigFilenameloadfunction to not catch errorsloadUserConfigfunction to load a provided config path with no catchloadUserConfigfunction to attempt to load the default config file for bothjsandcjsextensions (ignoringCannot finderror type if thrown), falling back to default config if none found