feat: [fme-8278]: Added update and delete CCM Perspective tool. Also Update recommendation stats and override savings (#88)

* [fme-8278] Removed refactor for code deduplication requested in PR review

* Merge branch 'master' into fme-8278_ccm_update_persp

* [fme-8278] Using slog library

* [fme-8278] Merge with master

* [fme-8278] Added destructive hint annotation to mutable tools

* [fme-8278] Update mutable recommendations tools description

* [fme-8278] Added prompt and Improved descriptions for mutable perspective APIs to ask for confirmation before proceed.

* [fme-8278] Applied AI review comments

* [fme-8278] Merge with master to solve conflitcs on PR

* [fme-8278] Added delete CCM Perspective tool

* [fme-8278] Added Update perspective tool

* [fme-8259] Added Override recommendations Savings and Update recommendation State

* [fme-8259] Applying some fixes from previous PR

* [fme-8233] Applying review changes

* [fme-8259] Adding Recommendations State update and Override Savings APIs (CCM)

* [fme8259] Added update recommedation state API

* [fme-8233] - Merge with master

* [fme-8233] Improving

Author: javrudsky

README.md

@@ -140,6 +140,8 @@ Toolset Name: `ccm`
 - `get_last_period_cost_ccm_perspective`:  Retrieves the cost for a specified period and perspective within a given account.
 - `get_last_twelve_months_cost_ccm_perspective`:  Retrieves a monthly cost breakdown for the past 12 months for a perspective within a specified account.
 - `create_ccm_perspective`: Creates a perspective for a specified account. 
+- `update_ccm_perspective`: Updates a perspective for a specified account. 
+- `delete_ccm_perspective`: Deletes a perspective for a specified account. 
 - `ccm_perspective_grid`: Query detailed cost perspective data in Harness Cloud Cost Management.
 - `ccm_perspective_time_series`: Query detailed cost perspective data, grouped by time in Harness Cloud Cost Management.
 - `ccm_perspective_summary_with_budget`: Query a summary of cost perspectives with budget information in Harness Cloud Cost Management, including detailed cost and budget data grouped by time.
@@ -150,6 +152,8 @@ Toolset Name: `ccm`
 - `list_ccm_recommendations`: Returns a filterable list of cost-optimization recommendations in Harness Cloud Cost Management.
 - `list_ccm_recommendations_by_resource_type`: Returns a aggregated statistics of cloud cost optimization recommendations grouped by resource type within a given account in Harness Cloud Cost Management.
 - `get_ccm_recommendations_stats`: Returns overall statistics for cloud cost optimization recommendations within a given account in Harness Cloud Cost Management.
+- `update_ccm_recommendation_state`: Marks a recommendation as Applied/Open/Ignored in Harness Cloud Cost Management
+- `override_ccm_recommendation_savings`: Overrides savings for a recommendation in Harness Cloud Cost Management
 - `get_ccm_commitment_coverage`: Get commitment coverage information for an account in Harness Cloud Cost Management
 - `get_ccm_commitment_savings`: Get commitment savings information for an account in Harness Cloud Cost Management
 - `get_ccm_commitment_utilisation`: Get commitment utilisation information for an account in Harness Cloud Cost Management broken down by Reserved Instances and Savings Plans in day wise granularity.

client/ccmperspectives.go

@@ -3,16 +3,17 @@ package client
 import (
 	"context"
 	"fmt"
-	"log/slog"
 	"github.com/harness/harness-mcp/client/dto"
 	"github.com/harness/harness-mcp/pkg/utils"
+	"log/slog"
 )
 const (
 	ccmPerspetiveDetailListPath = ccmBasePath + "/perspective/getAllPerspectives?accountIdentifier=%s"
 	ccmGetPerspectivePath = ccmBasePath + "/perspective"
 	ccmGetLastPeriodCostPerspectivePath = ccmBasePath + "/perspective/lastPeriodCost"
 	ccmGetLastTwelveMonthCostPerspectivePath = ccmBasePath + "/perspective/lastYearMonthlyCost"
 	ccmCreatePerspectivePath = ccmBasePath + "/perspective"
+	ccmDeletePerspectivePath = ccmCreatePerspectivePath 
 )
 
 func (r *CloudCostManagementService) ListPerspectivesDetail(ctx context.Context, scope dto.Scope, opts *dto.CCMListPerspectivesDetailOptions) (*dto.CCMPerspectivesDetailList, error) {
@@ -121,7 +122,7 @@ func (r *CloudCostManagementService) GetLastTwelveMonthsCostPerspective(ctx cont
 	return items, nil
 }
 
-func (r *CloudCostManagementService) CreatePerspective(ctx context.Context, scope dto.Scope, opts *dto.CCMCreatePerspectiveOptions) (*dto.CCMCreatePerspectiveResponse, error) {
+func (r *CloudCostManagementService) CreateOrUpdatePerspective(ctx context.Context, scope dto.Scope, opts *dto.CCMCreatePerspectiveOptions, update bool) (*dto.CCMCreatePerspectiveResponse, error) {
 	path := ccmCreatePerspectivePath
 	params := make(map[string]string)
 	if opts == nil {
@@ -134,20 +135,31 @@ func (r *CloudCostManagementService) CreatePerspective(ctx context.Context, scop
 	params["updateTotalCost"] = utils.BoolToString(opts.UpdateTotalCost)
 
 	// Body payload
-	body := map[string]interface{}{
+	body := map[string]any{
 		"name": opts.Body.Name,
 		"viewVersion": opts.Body.ViewVersion,
-		"viewTimeRange": map[string]interface{}{
+		"viewTimeRange": map[string]any{
 			"viewTimeRangeType": opts.Body.ViewTimeRange.ViewTimeRangeType,
 			"startTime": opts.Body.ViewTimeRange.StartTime,
 			"endTime": opts.Body.ViewTimeRange.EndTime,
 		},	
 		"viewType": opts.Body.ViewType,
 		"viewState": opts.Body.ViewState,
-		"viewRules": opts.Body.ViewRules,
 	}
 
-	awsPreferences := map[string]interface{}{
+	if len(opts.Body.ViewRules) > 0 {
+		body["viewRules"] = opts.Body.ViewRules
+	}
+
+	if opts.Body.ViewVisualization != (dto.CCMViewVisualization{}) {
+		body["viewVisualization"] = opts.Body.ViewVisualization
+	}	
+
+	if update {
+		body["uuid"] = opts.Body.UUID
+	}
+
+	awsPreferences := map[string]any{
 		"includeDiscounts": opts.Body.ViewPreferences.AwsPreferences.IncludeDiscounts,
 		"includeCredits": opts.Body.ViewPreferences.AwsPreferences.IncludeCredits,
 		"includeRefunds": opts.Body.ViewPreferences.AwsPreferences.IncludeRefunds,
@@ -158,19 +170,19 @@ func (r *CloudCostManagementService) CreatePerspective(ctx context.Context, scop
 		awsPreferences["awsCost"] = opts.Body.ViewPreferences.AwsPreferences.AwsCost
 	}
 
-	viewPreferences := map[string]interface{}{
+	viewPreferences := map[string]any{
 		"showAnomalies":        opts.Body.ViewPreferences.ShowAnomalies,
 		"includeOthers":        opts.Body.ViewPreferences.IncludeOthers,
 		"includeUnallocatedCost": opts.Body.ViewPreferences.IncludeUnallocatedCost,
 		"awsPreferences": awsPreferences,	
-		"gcpPreferences": map[string]interface{}{
+		"gcpPreferences": map[string]any{
 			"includeDiscounts": opts.Body.ViewPreferences.GcpPreferences.IncludeDiscounts,
 			"includeTaxes": opts.Body.ViewPreferences.GcpPreferences.IncludeTaxes,
 		},
 	}
 
 	if opts.Body.ViewPreferences.AzureViewPreferences.CostType != "" {
-		azureViewPreferences := map[string]interface{}{
+		azureViewPreferences := map[string]any{
 			"costType": opts.Body.ViewPreferences.AzureViewPreferences.CostType,
 		}
 		viewPreferences["azureViewPreferences"] = azureViewPreferences
@@ -186,12 +198,38 @@ func (r *CloudCostManagementService) CreatePerspective(ctx context.Context, scop
 		body["folderId"] = opts.Body.FolderId
 	}	
 
-	slog.Debug("Create Perspective", "Body", body)
 	item := new(dto.CCMCreatePerspectiveResponse)
-	err := r.Client.Post(ctx, path, params, body, &item)
-	if err != nil {
-		return nil, fmt.Errorf("failed to create cloud cost management perspective: %w", err)
+	if !update {
+		slog.Debug("Creating perspective", "body", body)
+		err := r.Client.Post(ctx, path, params, body, &item)
+		if err != nil {
+			return nil, fmt.Errorf("Failed to create cloud cost management perspective: %w", err)
+		}
+	} else {
+		slog.Debug("Updating perspective", "body", body)
+		err := r.Client.Put(ctx, path, params, body, &item)
+		if err != nil {
+			return nil, fmt.Errorf("Failed to update cloud cost management perspective: %w", err)
+		}
 	}
 
 	return item, nil
 }
+
+func (r *CloudCostManagementService) DeletePerspective(ctx context.Context, scope dto.Scope, accountId string, perspectiveId string) (*dto.CCMBaseResponse, error) {
+	path := ccmDeletePerspectivePath
+	params := make(map[string]string)
+	addScope(scope, params)
+
+	params["accountId"] = accountId
+	params["perspectiveId"] = perspectiveId
+
+	response := new(dto.CCMBaseResponse)
+
+	err := r.Client.Delete(ctx, path, params, nil, &response)
+	if err != nil {
+		return nil, fmt.Errorf("failed to delete a cloud cost management perspective: %w", err)
+	}
+
+	return response, nil
+}

client/ccmrecommendations.go

@@ -4,14 +4,16 @@ import (
 	"context"
 	"fmt"
 	"github.com/harness/harness-mcp/client/dto"
+	"strconv"
 )
 const (
 	ccmRecommendationsListPath = ccmBasePath + "/recommendation/overview/list?accountIdentifier=%s"
 	ccmRecommendationsByResourceTypeListPath = ccmBasePath + "/recommendation/overview/resource-type/stats?accountIdentifier=%s"
 	ccmRecommendationsStatsPath = ccmBasePath + "/recommendation/overview/stats?accountIdentifier=%s"
+	ccmUpdateRecommendationState = ccmBasePath + "/recommendation/overview/change-state?accountIdentifier=%s"
+	ccmOverrideRecommendationSavings = ccmBasePath + "/recommendation/overview/override-savings?accountIdentifier=%s"
 )
 
-
 func (r *CloudCostManagementService) ListRecommendations(ctx context.Context, scope dto.Scope, accountId string, options map[string]any) (*map[string]any, error) {
 
 	return r.getRecommendations(ctx, scope, accountId, options, ccmRecommendationsListPath)
@@ -27,6 +29,52 @@ func (r *CloudCostManagementService) GetRecommendationsStats(ctx context.Context
 	return r.getRecommendations(ctx, scope, accountId, options, ccmRecommendationsStatsPath)
 }
 
+func (r *CloudCostManagementService) UpdateRecommendationState(
+	ctx context.Context, 
+	scope dto.Scope, 
+	accountId string, 
+	recommendationId string,
+	state string,
+) (*map[string]any, error) {
+
+	path := fmt.Sprintf(ccmUpdateRecommendationState, accountId)
+	params := make(map[string]string)
+	params["recommendationId"] = recommendationId 
+	params["state"] = state
+
+	resp := new(map[string]any)
+
+	err := r.Client.Post(ctx, path, params, nil, &resp)
+	if err != nil {
+		return nil, fmt.Errorf("Failed to update cloud cost management Recommendation state: %w", err)
+	}
+
+	return resp, nil
+}
+
+func (r *CloudCostManagementService) OverrideRecommendationSavings(
+	ctx context.Context, 
+	scope dto.Scope, 
+	accountId string, 
+	recommendationId string,
+	savings float64,
+) (*map[string]any, error) {
+
+	path := fmt.Sprintf(ccmOverrideRecommendationSavings, accountId)
+	params := make(map[string]string)
+	params["recommendationId"] = recommendationId 
+	params["overriddenSavings"] = strconv.FormatFloat(savings, 'f', -1, 64)
+
+	resp := new(map[string]any)
+
+	err := r.Client.Put(ctx, path, params, nil, &resp)
+	if err != nil {
+		return nil, fmt.Errorf("Failed to override cloud cost management Recommendation savings: %w", err)
+	}
+
+	return resp, nil
+}
+
 func (r *CloudCostManagementService) getRecommendations(
 	ctx context.Context, 
 	scope dto.Scope,