Remove deprecated ember-flight-icon lazyEmbed flag (#3272)

Author: zamoore

.changeset/young-meals-knock.md

@@ -0,0 +1,5 @@
+---
+"@hashicorp/design-system-components": major
+---
+
+Removed support for deprecated `ember-flight-icons` `lazyEmbed` config

packages/components/addon-main.cjs

@@ -9,11 +9,8 @@ const flightIconSprite = require('@hashicorp/flight-icons/svg-sprite/svg-sprite-
 module.exports = {
   ...addonV1Shim(__dirname),
   contentFor(type, config) {
-    const legacyLazyEmbed = config?.emberFlightIcons?.lazyEmbed;
-
     if (
       !config.flightIconsSpriteLazyEmbed &&
-      !legacyLazyEmbed &&
       !config.__flightIconsSpriteLoaded &&
       type === 'body-footer'
     ) {

packages/components/src/instance-initializers/load-sprite.ts

@@ -6,11 +6,8 @@
 import config from 'ember-get-config';
 
 export async function initialize() {
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment
-  const legacyLazyEmbed = config?.emberFlightIcons?.lazyEmbed;
-
   // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-  if (config?.flightIconsSpriteLazyEmbed || legacyLazyEmbed) {
+  if (config?.flightIconsSpriteLazyEmbed) {
     const { default: svgSprite } = await import(
       '@hashicorp/flight-icons/svg-sprite/svg-sprite-module'
     );