Skip to content

Commit ae60492

Browse files
committed
Add more testings to cover full usage
1 parent 165be4a commit ae60492

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

internal/services/recoveryservices/backup_policy_vm_workload_resource.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ func (r BackupProtectionPolicyVMWorkloadResource) Arguments() map[string]*plugin
380380

381381
"settings": {
382382
Type: pluginsdk.TypeList,
383-
Required: true,
383+
Optional: true,
384384
MaxItems: 1,
385385
Elem: &pluginsdk.Resource{
386386
Schema: map[string]*pluginsdk.Schema{
@@ -392,7 +392,7 @@ func (r BackupProtectionPolicyVMWorkloadResource) Arguments() map[string]*plugin
392392

393393
"compression_enabled": {
394394
Type: pluginsdk.TypeBool,
395-
Optional: true,
395+
Required: true,
396396
Default: false,
397397
},
398398
},
@@ -405,6 +405,7 @@ func (r BackupProtectionPolicyVMWorkloadResource) Arguments() map[string]*plugin
405405
ForceNew: true,
406406
ValidateFunc: validation.StringInSlice([]string{
407407
string(protectionpolicies.WorkloadTypeSQLDataBase),
408+
string(protectionpolicies.WorkloadTypeSAPHanaDatabase),
408409
}, false),
409410
},
410411
}

internal/services/recoveryservices/recovery_services_vault_data_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ func (SiteRecoveryRecoveryVaultDataSource) Attributes() map[string]*pluginsdk.Sc
7070

7171
func (r SiteRecoveryRecoveryVaultDataSource) Read() sdk.ResourceFunc {
7272
return sdk.ResourceFunc{
73-
Timeout: 5 * time.Minute,
73+
Timeout: 20 * time.Minute,
7474
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
7575
client := metadata.Client.RecoveryServices.VaultsClient
7676
subscriptionId := metadata.Client.Account.SubscriptionId

internal/services/web/app_service.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ func schemaAppServiceSiteConfig() *pluginsdk.Schema {
262262
"v2.0",
263263
"v4.0",
264264
"v5.0",
265-
"v6.0",
266265
}, false),
267266
},
268267

internal/services/web/app_service_slot_resource.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func resourceAppServiceSlot() *pluginsdk.Resource {
4040
}),
4141

4242
Timeouts: &pluginsdk.ResourceTimeout{
43-
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
43+
Create: pluginsdk.DefaultTimeout(80 * time.Minute),
4444
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
4545
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
4646
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),

website/docs/r/app_service.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ A `connection_string` block supports the following:
125125

126126
* `name` - (Required) The name of the Connection String.
127127

128-
* `type` - (Required) The type of the Connection String. Possible values are `APIHub`, `Custom`, `DocDb`, `EventHub`, `MySQL`, `NotificationHub`, `PostgreSQL`, `RedisCache`, `ServiceBus`, `SQLAzure` and `SQLServer`.
128+
* `type` - (Required) The type of the Connection String. Possible values are `APIHub`, `Custom`, `DocDb`, `EventHub`, `MySQL`, `NotificationHub`, `PostgreSQL`, `RedisCache`, `ServiceBus`, `SQLAzure`, `TestMissingValueInSchema` and `SQLServer`.
129129

130130
* `value` - (Required) The value for the Connection String.
131131

0 commit comments

Comments
 (0)