Support google_compute_network patch to enable ULA internal IPv6 (#15895) (#25468)

[upstream:e05a490a5d04106ffba3ec40faa4b16e564c3ca5]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/15895.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed `google_compute_network` in-place update to enable `enable_ula_internal_ipv6`.
+```

google/services/compute/resource_compute_network.go

@@ -143,7 +143,6 @@ recreated to modify this field.`,
 			"enable_ula_internal_ipv6": {
 				Type:     schema.TypeBool,
 				Optional: true,
-				ForceNew: true,
 				Description: `Enable ULA internal ipv6 on this network. Enabling this feature will assign
 a /48 from google defined ULA prefix fd20::/20.`,
 			},
@@ -635,6 +634,56 @@ func resourceComputeNetworkUpdate(d *schema.ResourceData, meta interface{}) erro
 			return err
 		}
 	}
+	if d.HasChange("enable_ula_internal_ipv6") {
+		obj := make(map[string]interface{})
+
+		enableUlaInternalIpv6Prop, err := expandComputeNetworkEnableUlaInternalIpv6(d.Get("enable_ula_internal_ipv6"), d, config)
+		if err != nil {
+			return err
+		} else if v, ok := d.GetOkExists("enable_ula_internal_ipv6"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, enableUlaInternalIpv6Prop)) {
+			obj["enableUlaInternalIpv6"] = enableUlaInternalIpv6Prop
+		}
+
+		obj, err = resourceComputeNetworkUpdateEncoder(d, meta, obj)
+		if err != nil {
+			return err
+		}
+
+		url, err := tpgresource.ReplaceVars(d, config, "{{ComputeBasePath}}projects/{{project}}/global/networks/{{name}}")
+		if err != nil {
+			return err
+		}
+
+		headers := make(http.Header)
+
+		// err == nil indicates that the billing_project value was found
+		if bp, err := tpgresource.GetBillingProject(d, config); err == nil {
+			billingProject = bp
+		}
+
+		res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
+			Config:    config,
+			Method:    "PATCH",
+			Project:   billingProject,
+			RawURL:    url,
+			UserAgent: userAgent,
+			Body:      obj,
+			Timeout:   d.Timeout(schema.TimeoutUpdate),
+			Headers:   headers,
+		})
+		if err != nil {
+			return fmt.Errorf("Error updating Network %q: %s", d.Id(), err)
+		} else {
+			log.Printf("[DEBUG] Finished updating Network %q: %#v", d.Id(), res)
+		}
+
+		err = ComputeOperationWaitTime(
+			config, res, project, "Updating Network", userAgent,
+			d.Timeout(schema.TimeoutUpdate))
+		if err != nil {
+			return err
+		}
+	}
 	if d.HasChange("mtu") {
 		obj := make(map[string]interface{})
 

google/services/compute/resource_compute_network_test.go

@@ -657,6 +657,28 @@ func testAccCheckComputeNetworkIsCustomSubnet(t *testing.T, n string, network *c
 	}
 }
 
+func testAccCheckComputeNetworkIsUlaInternalIpv6Enabled(t *testing.T, n string, network *compute.Network, expectEnabled bool) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		config := acctest.GoogleProviderConfig(t)
+
+		found, err := config.NewComputeClient(config.UserAgent).Networks.Get(
+			config.Project, network.Name).Do()
+		if err != nil {
+			return err
+		}
+
+		if found.EnableUlaInternalIpv6 != expectEnabled {
+			return fmt.Errorf("does not match expected EnableUlaInternalIpv6 value")
+		}
+
+		if expectEnabled && found.InternalIpv6Range == "" {
+			return fmt.Errorf("should have InternalIPv6Range")
+		}
+
+		return nil
+	}
+}
+
 func testAccCheckComputeNetworkHasMtu(t *testing.T, n string, network *compute.Network, mtu int32) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		config := acctest.GoogleProviderConfig(t)
@@ -855,6 +877,38 @@ func TestAccComputeNetwork_networkBgpStandardModeDeleteMed(t *testing.T) {
 	})
 }
 
+func TestAccComputeNetwork_updateEnableUlaInternalIpv6(t *testing.T) {
+	t.Parallel()
+
+	var network compute.Network
+	var updatedNetwork compute.Network
+	suffixName := acctest.RandString(t, 10)
+	networkName := fmt.Sprintf("tf-test-network-enable-ula-%s", suffixName)
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeNetworkDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeNetwork_custom_subnet(networkName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeNetworkExists(
+						t, "google_compute_network.baz", &network),
+				),
+			},
+			{
+				Config: testAccComputeNetwork_ula(networkName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeNetworkExists(
+						t, "google_compute_network.baz", &updatedNetwork),
+					testAccCheckComputeNetworkWasUpdated(&updatedNetwork, &network),
+				),
+			},
+		},
+	})
+}
+
 func testAccComputeNetwork_basic(networkName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_network" "bar" {
@@ -873,6 +927,16 @@ resource "google_compute_network" "baz" {
 `, networkName)
 }
 
+func testAccComputeNetwork_ula(networkName string) string {
+	return fmt.Sprintf(`
+resource "google_compute_network" "baz" {
+  name                    = "%s"
+  auto_create_subnetworks = false
+  enable_ula_internal_ipv6 = true
+}
+`, networkName)
+}
+
 func testAccComputeNetwork_bgp(name, bgpBestPathSelectionMode, bgpAlwaysCompareMed, deleteBgpAlwaysCompareMed string) string {
 	var medLine, deleteMedLine string
 	if bgpAlwaysCompareMed != "" {