Skip to content

Update CI PR Checks to Include Block Nodes in the Loop #20081

@derektriley

Description

@derektriley

Background

Eventually we will want to set the writerMode to GRPC and not FILE_AND_GRPC. We should test that this actually functions as expected. In addition there will be updates to how our PR checks run due to StreamValidationOp depending on block files to be written by the consensus node.

We should update the PR check overrides for now to set the writerMode to FILE_AND_GRPC, and we could have the simulator write block files to disk and validate against them, or we could retrieve blocks via the block-node testcontainer.

Acceptance Criteria

  1. Update gradle build file for PR checks to set writerMode to FILE_AND_GRPC (as needed for PR checks which use simulators currently).
  2. Update the simulator to write blocks to disk as it's receiving them from the CN's or potentially after the PR check is done depending on memory constraints.
  3. Update StreamValidatonOp to validate the blocks from the sims

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions