test(fix): enhance error handling for eth_getBalance tests with missing or null parameters (#3838)

Signed-off-by: Michał Walczak <[email protected]>

Author: mwb-al

packages/server/tests/acceptance/rpc_batch2.spec.ts

@@ -606,28 +606,38 @@ describe('@api-batch-2 RPC Server Acceptance Tests', function () {
       expect(BigInt(balanceAtTx1Block).toString()).to.eq(manuallyCalculatedBalanceAtTx1Block.toString());
     });
 
-    it('should return error when the second parameter is missing in eth_getBalance', async function () {
-      const result = await relay.call(
-        RelayCalls.ETH_ENDPOINTS.ETH_GET_BALANCE,
-        [Address.NON_EXISTING_ADDRESS],
-        Utils.formatRequestIdMessage(requestId),
-      );
-
-      expect(result).to.have.property('error');
-      expect(result.error).to.have.property('message').to.include('Missing value for required parameter');
-    });
-
-    it('should return error when null is provided as the second parameter in eth_getBalance', async function () {
-      const result = await relay.call(
-        RelayCalls.ETH_ENDPOINTS.ETH_GET_BALANCE,
-        [Address.NON_EXISTING_ADDRESS, null],
-        Utils.formatRequestIdMessage(requestId),
-      );
-
-      expect(result).to.have.property('error');
-      expect(result.error)
-        .to.have.property('message')
-        .to.include('Invalid parameter 1: The value passed is not valid: null.');
+    it('should return an error when the second parameter is missing in eth_getBalance', async function () {
+      await expect(
+        relay.call(
+          RelayCalls.ETH_ENDPOINTS.ETH_GET_BALANCE,
+          [Address.NON_EXISTING_ADDRESS],
+          Utils.formatRequestIdMessage(requestId),
+        ),
+      ).to.eventually.be.rejected.and.satisfy((err: any) => {
+        try {
+          const body = JSON.parse(err?.info?.responseBody || '{}');
+          return body?.error?.message?.includes('Missing value for required parameter');
+        } catch {
+          return false;
+        }
+      }, 'Expected error message to include "Missing value for required parameter"');
+    });
+
+    it('should return an error when null is provided as the second parameter in eth_getBalance', async function () {
+      await expect(
+        relay.call(
+          RelayCalls.ETH_ENDPOINTS.ETH_GET_BALANCE,
+          [Address.NON_EXISTING_ADDRESS, null],
+          Utils.formatRequestIdMessage(requestId),
+        ),
+      ).to.eventually.be.rejected.and.satisfy((err: any) => {
+        try {
+          const body = JSON.parse(err?.info?.responseBody || '{}');
+          return body?.error?.message?.includes('Invalid parameter 1: The value passed is not valid: null.');
+        } catch {
+          return false;
+        }
+      }, 'Expected error message to include "Invalid parameter 1: The value passed is not valid: null."');
     });
   });