Check for read-only in sendRawTransaction

Signed-off-by: Luis Mastrangelo <[email protected]>

Author: acuarica

packages/relay/src/lib/services/ethService/transactionService/TransactionService.ts

@@ -262,6 +262,10 @@ export class TransactionService implements ITransactionService {
    * @returns {Promise<string | JsonRpcError>} A promise that resolves to the transaction hash or a JsonRpcError if an error occurs
    */
   async sendRawTransaction(transaction: string, requestDetails: RequestDetails): Promise<string | JsonRpcError> {
+    if (ConfigService.get('READ_ONLY')) {
+      throw predefined.UNSUPPORTED_OPERATION('Relay is in read-only mode');
+    }
+
     const transactionBuffer = Buffer.from(this.prune0x(transaction), 'hex');
     const parsedTx = Precheck.parseRawTransaction(transaction);
     const networkGasPriceInWeiBars = Utils.addPercentageBufferToGasPrice(

packages/relay/tests/lib/eth/eth_sendRawTransaction.spec.ts

@@ -16,7 +16,6 @@ import { expect, use } from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import { EventEmitter } from 'events';
 import pino from 'pino';
-import { Counter } from 'prom-client';
 import sinon, { useFakeTimers } from 'sinon';
 
 import { Eth, JsonRpcError, predefined } from '../../../src';
@@ -455,5 +454,18 @@ describe('@ethSendRawTransaction eth_sendRawTransaction spec', async function ()
         });
       });
     });
+
+    withOverriddenEnvsInMochaTest({ READ_ONLY: true }, () => {
+      it('should throw `UNSUPPORTED_OPERATION` when Relay is in Read-Only mode', async function () {
+        const signed = await signTransaction({ ...transaction, value: '0x1234567890' });
+        await RelayAssertions.assertRejection(
+          predefined.UNSUPPORTED_OPERATION('Relay is in read-only mode'),
+          ethImpl.sendRawTransaction,
+          false,
+          ethImpl,
+          [signed, requestDetails],
+        );
+      });
+    });
   });
 });