Skip to content

Commit 8637c48

Browse files
committed
fix: block hardhat & web3js empty response test due to MN regression
Signed-off-by: Logan Nguyen <[email protected]>
1 parent 154e907 commit 8637c48

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

tools/hardhat-example/test/rpc.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ describe('RPC', function () {
3636
expect(res).to.be.equal('initial_msg');
3737
});
3838

39-
it('should NOT throw exception upon empty hex response (0x)', async function () {
39+
// block this due to a regression in MN -> will be fixed in [email protected]
40+
// TODO: unblock this after [email protected]
41+
xit('should NOT throw exception upon empty hex response (0x)', async function () {
4042
const provider = new hre.ethers.getDefaultProvider(process.env.RELAY_ENDPOINT);
4143
const result = await provider.call({
4244
to: '0x00000000000000000000000000000000002e7a5d', // random non-existed address

tools/web3js-example/scripts/deployContract.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ module.exports = async (contractParam) => {
1616
});
1717
const contract = await greeter.send({
1818
from: wallet[0].address,
19-
gas: 300000,
2019
});
2120

2221
console.log(`Greeter deployed to: ${contract._address}`);

tools/web3js-example/test/rpc.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ describe('RPC', function () {
5454
expect(res).to.be.equal(updatedMsg);
5555
});
5656

57-
it('should NOT throw exception upon empty hex response (0x)', async function () {
57+
// block this due to a regression in MN -> will be fixed in [email protected]
58+
// TODO: unblock this after [email protected]
59+
xit('should NOT throw exception upon empty hex response (0x)', async function () {
5860
const web3 = new Web3(new Web3.providers.HttpProvider(process.env.RELAY_ENDPOINT));
5961
const result = await web3.eth.call({
6062
to: '0x00000000000000000000000000000000002e7a5d', // random non-existed address

0 commit comments

Comments
 (0)