added optional param used by remix

Signed-off-by: Simeon Nakov <[email protected]>

Author: simzzz

packages/relay/src/lib/debug.ts

@@ -129,13 +129,18 @@ export class DebugImpl implements Debug {
     // If no nested tracerConfig is provided AND no tracer is explicitly set,
     // check for top-level opcodeLogger config properties (defaults to opcodeLogger)
     if (!tracerObject?.tracerConfig && !tracerObject?.tracer && tracerObject) {
-      const { tracer: _, tracerConfig: __, ...topLevelConfig } = tracerObject;
+      const topLevelConfig = Object.fromEntries(
+        Object.entries(tracerObject).filter(([key]) => key !== 'tracer' && key !== 'tracerConfig'),
+      );
       // Only include valid opcodeLogger config properties
-      const validOpcodeLoggerKeys = ['enableMemory', 'disableStack', 'disableStorage'];
+      const validOpcodeLoggerKeys = ['enableMemory', 'disableStack', 'disableStorage', 'fullStorage'];
       const filteredConfig = Object.keys(topLevelConfig)
         .filter((key) => validOpcodeLoggerKeys.includes(key))
         .reduce((obj, key) => {
-          obj[key] = topLevelConfig[key];
+          // Filter out non-standard parameters that shouldn't be passed to the actual tracer
+          if (key !== 'fullStorage') {
+            obj[key] = topLevelConfig[key];
+          }
           return obj;
         }, {} as any);
 

packages/relay/src/lib/types/ITracerConfig.ts

@@ -8,6 +8,7 @@ export interface IOpcodeLoggerConfig {
   enableMemory?: boolean;
   disableStack?: boolean;
   disableStorage?: boolean;
+  fullStorage?: boolean; // Non-standard parameter sometimes sent by Remix - ignored in implementation
 }
 
 export type ITracerConfig = ICallTracerConfig | IOpcodeLoggerConfig;

packages/relay/src/lib/validators/objectTypes.ts

@@ -106,6 +106,11 @@ export const OBJECTS_VALIDATIONS: { [key: string]: IObjectSchema } = {
         nullable: false,
         required: false,
       },
+      fullStorage: {
+        type: 'boolean',
+        nullable: false,
+        required: false,
+      },
     },
   },
   tracerConfigWrapper: {
@@ -139,6 +144,11 @@ export const OBJECTS_VALIDATIONS: { [key: string]: IObjectSchema } = {
         nullable: false,
         required: false,
       },
+      fullStorage: {
+        type: 'boolean',
+        nullable: false,
+        required: false,
+      },
     },
   },
   transaction: {

packages/relay/tests/lib/validators/validators.spec.ts

@@ -692,6 +692,8 @@ describe('Validator', async () => {
       { enableMemory: true },
       { disableStack: false },
       { disableStorage: true },
+      { fullStorage: false }, // Non-standard but accepted for Remix compatibility
+      { enableMemory: true, disableStack: false, disableStorage: true, fullStorage: false },
       // Empty object
       {},
     ],
@@ -700,19 +702,19 @@ describe('Validator', async () => {
         input: { tracer: 'invalid', tracerConfig: {} },
         error: expectInvalidParam("'tracer' for TracerConfigWrapper", TYPES.tracerType.error, 'invalid'),
       },
-      // OpcodeLogger config properties with wrong tracer type
+      // Config properties with explicit tracer (not allowed in simplified model)
       {
         input: { tracer: Constants.TracerType.CallTracer, enableMemory: true },
         error: expectInvalidParam(
           1,
-          'opcodeLogger config properties for TracerConfigWrapper are only valid when tracer=opcodeLogger',
+          "Cannot specify tracer config properties at top level when 'tracer' is explicitly set for TracerConfigWrapper",
         ),
       },
       {
         input: { tracer: Constants.TracerType.CallTracer, disableStack: false },
         error: expectInvalidParam(
           1,
-          'opcodeLogger config properties for TracerConfigWrapper are only valid when tracer=opcodeLogger',
+          "Cannot specify tracer config properties at top level when 'tracer' is explicitly set for TracerConfigWrapper",
         ),
       },
       // Both top-level and nested config

packages/server/tests/acceptance/debug.spec.ts

@@ -647,13 +647,30 @@ describe('@debug API Acceptance Tests', function () {
           disableStorage: true,
         };
 
+        // Test with fullStorage parameter (Remix compatibility)
+        const topLevelWithFullStorage = {
+          enableMemory: true,
+          disableStack: false,
+          disableStorage: true,
+          fullStorage: false, // Non-standard parameter sent by Remix
+        };
+
         const topLevelResult = await relay.call(DEBUG_TRACE_TRANSACTION, [createChildTx.hash, topLevelFormat]);
         expect(topLevelResult).to.exist;
         expect(topLevelResult.structLogs).to.exist;
 
-        // Both formats should produce similar results
+        // Test that fullStorage parameter is accepted (Remix compatibility)
+        const fullStorageResult = await relay.call(DEBUG_TRACE_TRANSACTION, [
+          createChildTx.hash,
+          topLevelWithFullStorage,
+        ]);
+        expect(fullStorageResult).to.exist;
+        expect(fullStorageResult.structLogs).to.exist;
+
+        // All formats should produce similar results
         expect(topLevelResult.structLogs).to.have.length.greaterThan(0);
         expect(nestedResult.structLogs).to.have.length.greaterThan(0);
+        expect(fullStorageResult.structLogs).to.have.length.greaterThan(0);
       });
 
       it('should reject mixed format (top-level and nested config)', async function () {