fix: Strip leading zeros in signature v and s values coming from the mirror node, in tests. (#3241)

* fix: Strip leading zeros in signature v and s values.

Signed-off-by: Eric Badiere <[email protected]>

* fix: Added comments.

Signed-off-by: Eric Badiere <[email protected]>

---------

Signed-off-by: Eric Badiere <[email protected]>

Author: ebadiere

packages/ws-server/tests/acceptance/getTransactionByHash.spec.ts

@@ -117,8 +117,9 @@ describe('@web-socket-batch-2 eth_getTransactionByHash', async function () {
       expect(txReceipt.to).to.be.eq(accounts[1].address.toLowerCase());
       expect(txReceipt.blockHash).to.be.eq(expectedTxReceipt.block_hash.slice(0, 66));
       expect(txReceipt.hash).to.be.eq(expectedTxReceipt.hash);
-      expect(txReceipt.r).to.be.eq(expectedTxReceipt.r);
-      expect(txReceipt.s).to.be.eq(expectedTxReceipt.s);
+      // Must convert to quantity to compare and remove leading zeros
+      expect(txReceipt.r).to.be.eq(ethers.toQuantity(expectedTxReceipt.r));
+      expect(txReceipt.s).to.be.eq(ethers.toQuantity(expectedTxReceipt.s));
       expect(Number(txReceipt.v)).to.be.eq(expectedTxReceipt.v);
     });
   });
@@ -136,8 +137,9 @@ describe('@web-socket-batch-2 eth_getTransactionByHash', async function () {
       expect(txReceipt.to).to.be.eq(accounts[1].address.toLowerCase());
       expect(txReceipt.blockHash).to.be.eq(expectedTxReceipt.block_hash.slice(0, 66));
       expect(txReceipt.hash).to.be.eq(expectedTxReceipt.hash);
-      expect(txReceipt.r).to.be.eq(expectedTxReceipt.r);
-      expect(txReceipt.s).to.be.eq(expectedTxReceipt.s);
+      // Must convert to quantity to compare and remove leading zeros
+      expect(txReceipt.r).to.be.eq(ethers.toQuantity(expectedTxReceipt.r));
+      expect(txReceipt.s).to.be.eq(ethers.toQuantity(expectedTxReceipt.s));
       expect(Number(txReceipt.v)).to.be.eq(expectedTxReceipt.v);
     });
   });