Add tests

Signed-off-by: Luis Mastrangelo <[email protected]>

Author: acuarica

packages/relay/src/lib/relay.ts

@@ -336,9 +336,9 @@ export class Relay {
     const operator = this.clientMain.operatorAccountId!.toString();
     const balance = BigInt(await this.ethImpl.getBalance(operator, 'latest', {} as RequestDetails));
     if (balance === BigInt(0)) {
-      throw new Error(`Operator account \`${operator}\` has no balance`);
+      throw new Error(`Operator account '${operator}' has no balance`);
     } else {
-      this.logger.info(`Operator account \`${operator}\` has balance: ${balance}`);
+      this.logger.info(`Operator account '${operator}' has balance: ${balance}`);
     }
   }
 }

packages/relay/tests/lib/eth/eth-helpers.ts

@@ -36,17 +36,14 @@ export function generateEthTestEnv(fixedFeeHistory = false) {
   const logger = pino({ level: 'silent' });
   const registry = new Registry();
   const cacheService = CacheService.getInstance(CACHE_LEVEL.L1, registry);
-  // @ts-ignore
   const mirrorNodeInstance = new MirrorNodeClient(
     ConfigService.get('MIRROR_NODE_URL'),
     logger.child({ name: `mirror-node` }),
     registry,
     cacheService,
   );
 
-  // @ts-ignore
   const restMock = new MockAdapter(mirrorNodeInstance.getMirrorNodeRestInstance(), { onNoMatch: 'throwException' });
-  // @ts-ignore
   const web3Mock = new MockAdapter(mirrorNodeInstance.getMirrorNodeWeb3Instance(), { onNoMatch: 'throwException' });
 
   const duration = constants.HBAR_RATE_LIMIT_DURATION;

packages/relay/tests/lib/eth/eth_getBalance.spec.ts

@@ -2,10 +2,8 @@
 
 import { expect, use } from 'chai';
 import chaiAsPromised from 'chai-as-promised';
-import sinon from 'sinon';
 
 import { numberTo0x } from '../../../dist/formatters';
-import { SDKClient } from '../../../src/lib/clients';
 import constants from '../../../src/lib/constants';
 import { RequestDetails } from '../../../src/lib/types';
 import { buildCryptoTransferTransaction, overrideEnvsInMochaDescribe } from '../../helpers';
@@ -29,12 +27,9 @@ import { balancesByAccountIdByTimestampURL, generateEthTestEnv } from './eth-hel
 
 use(chaiAsPromised);
 
-let sdkClientStub: sinon.SinonStubbedInstance<SDKClient>;
-let getSdkClientStub: sinon.SinonStub;
-
 describe('@ethGetBalance using MirrorNode', async function () {
   this.timeout(10000);
-  const { restMock, hapiServiceInstance, ethImpl, cacheService } = generateEthTestEnv();
+  const { restMock, ethImpl, cacheService } = generateEthTestEnv();
 
   const requestDetails = new RequestDetails({ requestId: 'eth_getBalanceTest', ipAddress: '0.0.0.0' });
 
@@ -45,13 +40,10 @@ describe('@ethGetBalance using MirrorNode', async function () {
     await cacheService.clear(requestDetails);
     restMock.reset();
 
-    sdkClientStub = sinon.createStubInstance(SDKClient);
-    getSdkClientStub = sinon.stub(hapiServiceInstance, 'getSDKClient').returns(sdkClientStub);
     restMock.onGet('network/fees').reply(200, JSON.stringify(DEFAULT_NETWORK_FEES));
   });
 
   this.afterEach(() => {
-    getSdkClientStub.restore();
     restMock.resetHandlers();
   });
 

packages/relay/tests/lib/relay.spec.ts

@@ -1,14 +1,15 @@
 // SPDX-License-Identifier: Apache-2.0
 
+import MockAdapter from 'axios-mock-adapter';
 import chai, { expect } from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import fs from 'fs';
 import pino from 'pino';
 import { Registry } from 'prom-client';
 import sinon from 'sinon';
-import { CacheService } from '../../src/lib/services/cacheService/cacheService';
 
 import { Relay } from '../../src';
+import { CacheService } from '../../src/lib/services/cacheService/cacheService';
 import { overrideEnvsInMochaDescribe, withOverriddenEnvsInMochaTest } from '../helpers';
 
 chai.use(chaiAsPromised);
@@ -103,4 +104,60 @@ describe('Relay', () => {
       });
     });
   });
+
+  describe('ensureOperatorHasBalance', function () {
+    withOverriddenEnvsInMochaTest({ READ_ONLY: true }, () => {
+      it('should never throw', async function () {
+        await expect(relay.ensureOperatorHasBalance()).to.not.be.rejectedWith();
+      });
+    });
+
+    withOverriddenEnvsInMochaTest({ READ_ONLY: false }, () => {
+      let restMock: MockAdapter;
+      let operatorId: string;
+
+      beforeEach(() => {
+        const mirrorNodeInstance = relay.mirrorClient().getMirrorNodeRestInstance();
+        restMock = new MockAdapter(mirrorNodeInstance, { onNoMatch: 'throwException' });
+        // @ts-expect-error: Property 'clientMain' is private and only accessible within class 'Relay'
+        const clientMain = relay.clientMain;
+        operatorId = clientMain.operatorAccountId!.toString();
+      });
+
+      afterEach(() => {
+        restMock.restore();
+      });
+
+      it('should not throw when operator has balance', async function () {
+        const balance = {
+          account: operatorId,
+          balance: {
+            balance: 99960581137,
+          },
+        };
+        restMock.onGet(`accounts/${operatorId}?limit=100`).reply(200, JSON.stringify(balance));
+        await expect(relay.ensureOperatorHasBalance()).to.not.be.rejectedWith();
+      });
+
+      it('should throw when operator has no balance', async function () {
+        const balance = {
+          account: operatorId,
+          balance: {
+            balance: 0,
+          },
+        };
+        restMock.onGet(`accounts/${operatorId}?limit=100`).reply(200, JSON.stringify(balance));
+
+        const message = `Operator account '${operatorId}' has no balance`;
+        await expect(relay.ensureOperatorHasBalance()).to.be.rejectedWith(message);
+      });
+
+      it('should throw when operator has not been found', async function () {
+        restMock.onGet(`accounts/${operatorId}?limit=100`).reply(404, JSON.stringify({}));
+
+        const message = `Operator account '${operatorId}' has no balance`;
+        await expect(relay.ensureOperatorHasBalance()).to.be.rejectedWith(message);
+      });
+    });
+  });
 });