Skip to content

Commit f723d52

Browse files
committed
changes so code can reject unexpected params
Signed-off-by: Konstantina Blazhukova <[email protected]>
1 parent 5494871 commit f723d52

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

packages/relay/src/lib/validators/objectTypes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const OBJECTS_VALIDATIONS: { [key: string]: IObjectSchema } = {
102102
tracerConfigWrapper: {
103103
name: 'TracerConfigWrapper',
104104
failOnEmpty: true,
105-
failOnUnexpectedParams: false,
105+
failOnUnexpectedParams: true,
106106
properties: {
107107
tracer: {
108108
type: 'tracerType',

packages/server/tests/acceptance/debug.spec.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('@debug API Acceptance Tests', function () {
5757
CALL_TRACER_TOP_ONLY: { tracer: TracerType.CallTracer, tracerConfig: { onlyTopCall: true } },
5858
PRESTATE_TRACER: { tracer: TracerType.PrestateTracer },
5959
PRESTATE_TRACER_TOP_ONLY: { tracer: TracerType.PrestateTracer, tracerConfig: { onlyTopCall: true } },
60-
PRESTATE_TRACER_TOP_ONLY_FALSE: { tracer: TracerType.PrestateTracer, onlyTopCall: false },
60+
PRESTATE_TRACER_TOP_ONLY_FALSE: { tracer: TracerType.PrestateTracer, tracerConfig: { onlyTopCall: false } },
6161
OPCODE_LOGGER: { tracer: TracerType.OpcodeLogger },
6262
OPCODE_WITH_MEMORY: { tracer: TracerType.OpcodeLogger, tracerConfig: { enableMemory: true } },
6363
OPCODE_WITH_MEMORY_AND_STACK: {
@@ -141,8 +141,11 @@ describe('@debug API Acceptance Tests', function () {
141141
const blockNumber = receipt.blockNumber;
142142

143143
// Call debug_traceBlockByNumber with CallTracer
144-
const tracerConfig = { tracer: TracerType.CallTracer, onlyTopCall: false };
145-
const result = await relay.call(DEBUG_TRACE_BLOCK_BY_NUMBER, [blockNumber, tracerConfig], requestId);
144+
const result = await relay.call(
145+
DEBUG_TRACE_BLOCK_BY_NUMBER,
146+
[blockNumber, TRACER_CONFIGS.CALL_TRACER_TOP_ONLY_FALSE],
147+
requestId,
148+
);
146149

147150
expect(result).to.be.an('array');
148151
expect(result.length).to.be.at.least(1);
@@ -183,8 +186,11 @@ describe('@debug API Acceptance Tests', function () {
183186
const blockNumber = receipt.blockNumber;
184187

185188
// Call debug_traceBlockByNumber with CallTracer
186-
const tracerConfig = { tracer: TracerType.CallTracer, onlyTopCall: false };
187-
const result = await relay.call(DEBUG_TRACE_BLOCK_BY_NUMBER, [blockNumber, tracerConfig], requestId);
189+
const result = await relay.call(
190+
DEBUG_TRACE_BLOCK_BY_NUMBER,
191+
[blockNumber, TRACER_CONFIGS.CALL_TRACER_TOP_ONLY_FALSE],
192+
requestId,
193+
);
188194

189195
expect(result).to.be.an('array');
190196
expect(result.length).to.be.at.least(1);
@@ -276,7 +282,7 @@ describe('@debug API Acceptance Tests', function () {
276282
// First trace with onlyTopCall=false (default)
277283
const fullResult = await relay.call(
278284
DEBUG_TRACE_BLOCK_BY_NUMBER,
279-
[blockNumber, TRACER_CONFIGS.PRESTATE_TRACER_TOP_ONLY_FALSE],
285+
[blockNumber, TRACER_CONFIGS.PRESTATE_TRACER_TOP_ONLY],
280286
requestId,
281287
);
282288

@@ -396,7 +402,7 @@ describe('@debug API Acceptance Tests', function () {
396402
});
397403

398404
it('should fail with INVALID_PARAMETER when given an invalid tracer configuration', async function () {
399-
const invalidTracerConfig = { tracer: 'InvalidTracer', onlyTopCall: false };
405+
const invalidTracerConfig = { tracer: 'InvalidTracer', tracerConfig: { onlyTopCall: false } };
400406
await relay.callFailing(
401407
DEBUG_TRACE_BLOCK_BY_NUMBER,
402408
[numberTo0x(deploymentBlockNumber), invalidTracerConfig],

0 commit comments

Comments
 (0)