Skip to content

Conversation

@mwb-al
Copy link
Contributor

@mwb-al mwb-al commented Jun 17, 2025

Description:

Update getTransactionCount signature to always require a blockNumOrTag parameter

Related issue(s):

Fixes #3840

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mwb-al mwb-al requested review from a team as code owners June 17, 2025 13:12
@mwb-al mwb-al requested a review from konstantinabl June 17, 2025 13:12
@lfdt-bot
Copy link

lfdt-bot commented Jun 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@simzzz simzzz self-requested a review June 26, 2025 13:55
@arianejasuwienas arianejasuwienas merged commit c4b9c0a into hiero-ledger:main Jul 1, 2025
39 of 41 checks passed
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage        ?   82.13%           
=======================================
  Files           ?       89           
  Lines           ?     5133           
  Branches        ?     1035           
=======================================
  Hits            ?     4216           
  Misses          ?      586           
  Partials        ?      331           
Flag Coverage Δ
config-service 94.04% <ø> (?)
relay 81.29% <100.00%> (?)
server 80.81% <ø> (?)
ws-server 61.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/eth.ts 72.18% <ø> (ø)
...rvices/ethService/accountService/AccountService.ts 83.43% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align eth_getTransactionCount parameter validation with Ethereum's OpenRPC specification

6 participants