feat: add replaced_by_tx_id to replaced mempool transactions (#2271)

* feat: add replacing_tx_id

* fix: schema

* fix: tweak name

* style: lint

* style: nit

* fix: tests

* test: last

* fix: revert launch

* fix: rbf on insert

* fix: rbf upon confirmation

* test: sponsored tx

* fix: tx counts

* style: nit

* style: lint

* fix: limits

* fix: tests

* fix: tests 2

* fix: tests 3

* fix: rosetta tests

Author: rafaelcr

migrations/1715844926068_add-replacing-txid.js

@@ -0,0 +1,12 @@
+/* eslint-disable camelcase */
+/** @param { import("node-pg-migrate").MigrationBuilder } pgm */
+
+exports.up = pgm => {
+  pgm.addColumn('mempool_txs', {
+    replaced_by_tx_id: {
+      type: 'bytea', 
+    }
+  });
+};
+
+

migrations/1747760018771_txs-sender-nonce-indexes.js

@@ -0,0 +1,21 @@
+/* eslint-disable camelcase */
+
+exports.shorthands = undefined;
+
+exports.up = pgm => {
+  pgm.dropIndex('txs', ['sender_address']);
+  pgm.createIndex('txs', ['sender_address', 'nonce'], {
+    where: 'canonical = true AND microblock_canonical = true',
+  });
+  pgm.dropIndex('txs', ['sponsor_address']);
+  pgm.createIndex('txs', ['sponsor_address', 'nonce'], {
+    where: 'sponsor_address IS NOT NULL AND canonical = true AND microblock_canonical = true',
+  });
+};
+
+exports.down = pgm => {
+  pgm.dropIndex('txs', ['sender_address', 'nonce']);
+  pgm.createIndex('txs', ['sender_address']);
+  pgm.dropIndex('txs', ['sponsor_address', 'nonce']);
+  pgm.createIndex('txs', ['sponsor_address']);
+};

src/api/controllers/db-controller.ts

@@ -1147,6 +1147,7 @@ function parseDbAbstractMempoolTx(
   const abstractMempoolTx: AbstractMempoolTransaction = {
     ...baseTx,
     tx_status: getTxStatusString(dbMempoolTx.status) as MempoolTransactionStatus,
+    replaced_by_tx_id: dbMempoolTx.replaced_by_tx_id ?? null,
     receipt_time: dbMempoolTx.receipt_time,
     receipt_time_iso: unixEpochToIso(dbMempoolTx.receipt_time),
   };

src/api/schemas/entities/transactions.ts

@@ -429,6 +429,11 @@ export const AbstractMempoolTransactionProperties = {
       description: 'Status of the transaction',
     }
   ),
+  replaced_by_tx_id: Nullable(
+    Type.String({
+      description: 'ID of another transaction which replaced this one',
+    })
+  ),
   receipt_time: Type.Integer({
     description:
       'A unix timestamp (in seconds) indicating when the transaction broadcast was received by the node.',

src/datastore/common.ts

@@ -306,6 +306,8 @@ export interface DbMempoolFeePriority {
 export interface DbMempoolTx extends BaseTx {
   pruned: boolean;
 
+  replaced_by_tx_id?: string;
+
   receipt_time: number;
 
   post_conditions: string;
@@ -897,6 +899,7 @@ export interface MempoolTxQueryResult {
   type_id: number;
   anchor_mode: number;
   status: number;
+  replaced_by_tx_id?: string;
   receipt_time: number;
   receipt_block_height: number;
 
@@ -1242,6 +1245,7 @@ export interface MempoolTxInsertValues {
   type_id: DbTxTypeId;
   anchor_mode: DbTxAnchorMode;
   status: DbTxStatus;
+  replaced_by_tx_id: PgBytea | null;
   receipt_time: number;
   receipt_block_height: number;
   post_conditions: PgBytea;

src/datastore/helpers.ts

@@ -133,6 +133,7 @@ export const MEMPOOL_TX_COLUMNS = [
   'type_id',
   'anchor_mode',
   'status',
+  'replaced_by_tx_id',
   'receipt_time',
   'receipt_block_height',
   'post_conditions',
@@ -302,6 +303,7 @@ export function parseMempoolTxQueryResult(result: MempoolTxQueryResult): DbMempo
     type_id: result.type_id as DbTxTypeId,
     anchor_mode: result.anchor_mode as DbTxAnchorMode,
     status: result.status,
+    replaced_by_tx_id: result.replaced_by_tx_id,
     receipt_time: result.receipt_time,
     post_conditions: result.post_conditions,
     fee_rate: BigInt(result.fee_rate),
@@ -1283,6 +1285,7 @@ export function convertTxQueryResultToDbMempoolTx(txs: TxQueryResult[]): DbMempo
           ? BigInt(tx.token_transfer_amount)
           : tx.token_transfer_amount,
       sponsor_address: tx.sponsor_address ?? undefined,
+      status: DbTxStatus.Pending,
     });
     dbMempoolTxs.push(dbMempoolTx);
   }