migrate to Microsoft.Extensions.Logging as the logging infrastructure

[JaggerJo]

🚀 Feature Request

Since Microsoft.Extensions.Logging (Abstractions) launched it slowly became the de facto standard logging abstraction in .NET.

Most (if not all) logging libraries offer integrations or directly implement ILogger/ILoggerFactory.

🔈 Motivation

Currently referencing the Hive client also adda an indirect reference to NLog. That would be resolved by only referencing the common logger interfaces but no concrete implementation.

🛰 Alternatives

Keep it as it is and live with the dependency.

📎 Additional context

[pglombardo]

Hi @JaggerJo - I agree. Thanks for pointing this out. This will happen much sooner than later.

[pglombardo]

Hi @JaggerJo - just an update that I've tried a few iterations and Microsoft.Extensions.Logging is atrociously slow. Slight improvements as I progress but still way slower than NLog.

We will likely not merge this PR as switching to Microsoft.Extensions.Logging causes a severe performance degradation. This was even after implementing Microsoft suggested performance best practices.

If we replace NLog eventually, I may have to implement a custom internal logger.

See #295

I'll revisit in a couple days.

[JaggerJo]

Hi @JaggerJo - just an update that I've tried a few iterations and Microsoft.Extensions.Logging is atrociously slow. Slight improvements as I progress but still way slower than NLog.

We will likely not merge this PR as switching to Microsoft.Extensions.Logging causes a severe performance degradation. This was even after implementing Microsoft suggested performance best practices.

If we replace NLog eventually, I may have to implement a custom internal logger.

See #295

I'll revisit in a couple days.

That's interesting, I did not expect that.

Any idea what leads to the massive performance difference?

[pglombardo]

Me neither honestly. We've had multiple requests for this and the change makes sense.

Looking at MQTTNet, they use their own custom logger with an ILogger like interface - which I might understand the motive why now.

For now, I'll let it sit for a couple days, think it over and make sure I didn't overlook anything.