Look schema for update (#111)

* Check valid schema for update

* fix merge options

* fix style & return value

* simplify

Author: pvizeli

hassio/addons/addon.py

@@ -336,6 +336,36 @@ def schema(self):
             return vol.Schema(dict)
         return vol.Schema(vol.All(dict, validate_options(raw_schema)))
 
+    def test_udpate_schema(self):
+        """Check if the exists config valid after update."""
+        if not self.is_installed or self.is_detached:
+            return True
+
+        # load next schema
+        new_raw_schema = self.data.cache[self._id][ATTR_SCHEMA]
+        default_options = self.data.cache[self._id][ATTR_OPTIONS]
+
+        # if disabled
+        if isinstance(new_raw_schema, bool):
+            return True
+
+        # merge options
+        options = {
+            **self.data.user[self._id][ATTR_OPTIONS],
+            **default_options,
+        }
+
+        # create voluptuous
+        new_schema = \
+            vol.Schema(vol.All(dict, validate_options(new_raw_schema)))
+
+        # validate
+        try:
+            new_schema(options)
+        except vol.Invalid:
+            return False
+        return True
+
     async def install(self, version=None):
         """Install a addon."""
         if self.config.arch not in self.supported_arch:

hassio/addons/validate.py

@@ -98,7 +98,7 @@ def _migrate_startup(value):
 # pylint: disable=no-value-for-parameter
 SCHEMA_ADDON_USER = vol.Schema({
     vol.Required(ATTR_VERSION): vol.Coerce(str),
-    vol.Required(ATTR_OPTIONS): dict,
+    vol.Optional(ATTR_OPTIONS, default={}): dict,
     vol.Optional(ATTR_AUTO_UPDATE, default=False): vol.Boolean(),
     vol.Optional(ATTR_BOOT):
         vol.In([BOOT_AUTO, BOOT_MANUAL]),

hassio/tasks.py

@@ -27,8 +27,14 @@ async def _addons_update():
             if not addon.is_installed or not addon.auto_update:
                 continue
 
-            if addon.version_installed != addon.last_version:
+            if addon.version_installed == addon.last_version:
+                continue
+
+            if addon.test_udpate_schema():
                 tasks.append(addon.update())
+            else:
+                _LOGGER.warning(
+                    "Addon %s will be ignore, schema tests fails", addon.slug)
 
         if tasks:
             _LOGGER.info("Addon auto update process %d tasks", len(tasks))