Skip to content

Commit 04632f8

Browse files
committed
fix: umd loading not working 100%
Signed-off-by: Gordon Smith <[email protected]>
1 parent 9ac24d5 commit 04632f8

File tree

7 files changed

+19
-18
lines changed

7 files changed

+19
-18
lines changed

.vscode/launch.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@
9797
{
9898
"name": "esbuild",
9999
"type": "node",
100-
"program": "${workspaceFolder}/esbuild.mjs",
100+
"program": "${workspaceFolder}/packages/wasm/esbuild.js",
101+
"cwd": "${workspaceFolder}/packages/wasm",
101102
"request": "launch",
102103
"args": [],
103104
"skipFiles": [

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ set(EM_LINK_FLAGS
1717
"-sINVOKE_RUN=0"
1818
"-sALLOW_MEMORY_GROWTH=1"
1919
# "-sWASM=1"
20-
"-sENVIRONMENT=web"
20+
"-sENVIRONMENT=webview"
2121
"-sFILESYSTEM=0"
2222
# "-sMINIMAL_RUNTIME=1"
2323
"-sMODULARIZE=1"

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ <h3>UMD 1</h3>
7171
<script src="https://cdn.jsdelivr.net/npm/@hpcc-js/wasm/dist/graphviz.umd.js"></script>
7272
<!-- <script src="./packages/wasm/dist/graphviz.umd.js"></script> -->
7373
<script>
74-
var hpccWasm = window["@hpcc-js/wasm"];
74+
var hpccWasm = window["@hpcc-js/wasm/graphviz"];
7575
hpccWasm.Graphviz.load().then(graphviz => {
7676
var svg = graphviz.layout(dot, "svg", "dot");
7777
document.getElementById("UMD1").innerHTML = svg;

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
},
7979
"devDependencies": {
8080
"@eslint/js": "9.30.1",
81-
"@hpcc-js/esbuild-plugins": "1.4.7",
81+
"@hpcc-js/esbuild-plugins": "1.4.8",
8282
"@types/emscripten": "1.40.1",
8383
"@types/node": "24.0.10",
8484
"@types/yargs": "17.0.33",

packages/wasm/esbuild.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import { bothTpl } from "@hpcc-js/esbuild-plugins";
22

33
// config ---
44
await Promise.all([
5-
bothTpl("src/base91.ts", "dist/base91", undefined, "@hpcc-js/wasm"),
6-
bothTpl("src/duckdb.ts", "dist/duckdb", undefined, "@hpcc-js/wasm"),
7-
bothTpl("src/graphviz.ts", "dist/graphviz", undefined, "@hpcc-js/wasm"),
8-
bothTpl("src/expat.ts", "dist/expat", undefined, "@hpcc-js/wasm"),
9-
bothTpl("src/zstd.ts", "dist/zstd", undefined, "@hpcc-js/wasm")
5+
bothTpl("src/base91.ts", "dist/base91", { libraryName: "@hpcc-js/wasm/base91" }),
6+
bothTpl("src/duckdb.ts", "dist/duckdb", { libraryName: "@hpcc-js/wasm/duckdb" }),
7+
bothTpl("src/graphviz.ts", "dist/graphviz", { libraryName: "@hpcc-js/wasm/graphviz" }),
8+
bothTpl("src/expat.ts", "dist/expat", { libraryName: "@hpcc-js/wasm/expat" }),
9+
bothTpl("src/zstd.ts", "dist/zstd", { libraryName: "@hpcc-js/wasm/zstd" })
1010
]);
11-
await bothTpl("src/index.ts", "dist/index", undefined, "@hpcc-js/wasm", ["./base91.js", "./duckdb.js", "./expat.js", "./graphviz.js", "./zstd.js"]);
11+
await bothTpl("src/index.ts", "dist/index", { libraryName: "@hpcc-js/wasm", external: ["./base91.js", "./duckdb.js", "./expat.js", "./graphviz.js", "./zstd.js"] });

packages/wasm/src/index.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export namespace Base91 {
22
export function load() {
3-
return import("./base91.ts").then(mod => mod.Base91.load());
3+
return import("./base91.js").then(mod => mod.Base91.load());
44
}
55
}
66
export namespace DuckDB {
@@ -10,16 +10,16 @@ export namespace DuckDB {
1010
}
1111
export namespace Expat {
1212
export function load() {
13-
return import("./expat.ts").then(mod => mod.Expat.load());
13+
return import("./expat.js").then(mod => mod.Expat.load());
1414
}
1515
}
1616
export namespace Graphviz {
1717
export function load() {
18-
return import("./graphviz.ts").then(mod => mod.Graphviz.load());
18+
return import("./graphviz.js").then(mod => mod.Graphviz.load());
1919
}
2020
}
2121
export namespace Zstd {
2222
export function load() {
23-
return import("./zstd.ts").then(mod => mod.Zstd.load());
23+
return import("./zstd.js").then(mod => mod.Zstd.load());
2424
}
2525
}

0 commit comments

Comments
 (0)