Skip to content

Commit cdcce3e

Browse files
committed
Merge branch 'master' into release
2 parents af0ac87 + 2ffc40e commit cdcce3e

File tree

5 files changed

+38
-9
lines changed

5 files changed

+38
-9
lines changed

DEVELOPMENT.md

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,38 @@
1-
### Internal Glossary
1+
# Release Guide
22

3-
#### `value_set`
3+
## `htmlburger/carbon-fields`
4+
5+
1. Merge all changes for the new version into `master`
6+
1. Bump version numbers in `config.php` and `package.json` according to SemVer
7+
1. Commit bumped version changes to `master`
8+
1. Checkout `release`
9+
1. Merge `master` into `release`. NEVER merge `release` into any other branch - only merge branches INTO `release`.
10+
1. Run `npm install && npm run build`
11+
1. You should now have changes ONLY in the /assets/dist/ directory - any changes outside this directory mean that you have a dirty working copy. Never commit anything else into `release` except /assets/dist/ changes.
12+
1. Commit the /assets/dist/ changes to `release`
13+
1. `git push --all`
14+
1. Create a new release in [Github](https://github.com/htmlburger/carbon-fields-plugin/releases/new) from the `release` branch
15+
1. Enter the new version you set in `config.php` for `Tag version` and `Title`
16+
1. Add a changelog for `Description`
17+
1. Click `Publish release`
18+
19+
## `htmlburger/carbon-fields-plugin`
20+
21+
1. Update the version in `carbon-fields-plugin.php` and `composer.json` for `htmlburger/carbon-fields` to match the newly released version
22+
1. Commit to `master`
23+
1. Create a new release in [Github](https://github.com/htmlburger/carbon-fields-plugin/releases/new) from the `release` branch
24+
1. Enter the new version for `Tag version` and `Title` (you can skip the changelog)
25+
1. Click `Publish release`
26+
27+
# Internal Glossary
28+
29+
## `value_set`
430

531
Represents a single field value. `Complex_Field` uses a `value_tree` instead which contains a `value_set` for every child field including the `Complex_Field` itself.
632

733
_Note: The `Value_Set` class will always return a fully formatted `value_set` with all of it's properties OR `null`_
834

9-
##### Schema
35+
### Schema
1036

1137
array(
1238
array(

assets/css/modules/_fields.complex.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
.carbon-groups-holder .carbon-group-actions a:focus { box-shadow: none; outline: none; }
3535
.carbon-groups-holder .carbon-group-actions a:before { display: block; text-indent: 0; }
3636

37-
.carbon-groups-holder .collapsed .carbon-btn-collapse:before { content: '\f140'; }
37+
.carbon-groups-holder > .collapsed > .carbon-group-actions > .carbon-btn-collapse:before { content: '\f140'; }
3838

3939
.carbon-groups-holder .carbon-group-actions .carbon-btn-remove:hover { color: $color-border-darkgrey; }
4040

@@ -110,8 +110,8 @@
110110
.carbon-empty-row:not(.carbon-empty-row-visible) ~ .layout-tabbed-horizontal + .carbon-actions,
111111
.carbon-empty-row:not(.carbon-empty-row-visible) ~ .layout-tabbed-vertical + .carbon-actions { display: none !important; }
112112

113-
.layout-tabbed-horizontal .collapsed > .fields-container,
114-
.layout-tabbed-vertical .collapsed > .fields-container { display: flex; }
113+
.layout-tabbed-horizontal > .carbon-groups-holder > .collapsed > .fields-container,
114+
.layout-tabbed-vertical > .carbon-groups-holder > .collapsed > .fields-container { display: flex; }
115115

116116
/* Vertical Tabbed Layout */
117117

assets/js/fields/sagas/validation.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ export function* workerValidate(validator, fieldId, debounce, action) {
7575

7676
// Perform the validation.
7777
let error = yield call(validator, field);
78-
error = yield call(userValidateField, fieldId, error);
78+
const userError = yield call(userValidateField, fieldId, error);
79+
if ( ! isUndefined(userError) ) {
80+
error = userError;
81+
}
7982

8083
// Update the UI.
8184
if (isNull(error)) {

config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
# Define version constant
66
if ( ! defined( __NAMESPACE__ . '\VERSION' ) ) {
7-
define( __NAMESPACE__ . '\VERSION', '2.0.1' );
7+
define( __NAMESPACE__ . '\VERSION', '2.0.3' );
88
}
99

1010
# Define root directory

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "carbon-fields",
3-
"version": "2.0.2",
3+
"version": "2.0.3",
44
"description": "WordPress developer-friendly custom fields for post types, taxonomy terms, users, comments, widgets, options, navigation menus and more.",
55
"main": "index.js",
66
"directories": {

0 commit comments

Comments
 (0)