-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Hello!
I've been dealing with an annoying edge case where I'm losing video playback during a momentary unmount. Trying to dig into things, so I've tried to spin up a local development environment for this repo.
Looks like an npm install
no longer works as expected - presumably some dependencies have drifted and the lack of package-lock means there's no reference to the correct versions?
Forked the repo and ran a quick CI run with a dummy commit (adding a newline to the README) and looks like the CI builds will currently fail too:
https://github.com/tr00st/react-reverse-portal/actions/runs/18157930903/job/51681979323
Running with a fresh clone, tried node 16, 18, 20, 22, 24 via nvm
, same issue as is hitting on the CI build.
Adding a dev dependency to @types/node@16
works around the issue locally, but following that, storybook builds fail, which I'm worried might imply some deeper issues, or something I'm doing wrong my end.
Logs from failing npm install
- worked around with npm install @types/node@16 --save-dev
:
After installation of @types/node
, storybook failure:
Not sure the best way to proceed - I'll probably keep hacking at it on my end. Happy to submit a PR if I get to a minimal set of fixes if it is dependency-related as per my guess, but not sure how messy/heavy-handed that'll get 😄