Commit 7291a10
authored
[Inference] Let's use lowercase left/right truncation direction parameter (#1841)
First spotted by @alvarobartt on
[slack](https://huggingface.slack.com/archives/C064Z3GRU3U/p1762871481747849?thread_ts=1743434022.621759&cid=C064Z3GRU3U)
(internal).
The `FeatureExtractionInputTruncationDirection` parameter defined in the
feature-extraction specs currently have capitalized values `Left` /
`Right`. This comes from TEI implementation from which we pulled the
specs. Let's switch it to lowercase values for consistency with all
other specs.
In addition to this PR, we should:
- update TEI to accept `left`/`right` (not even sure we want backward
compatibility on this) => @alvarobartt would you be able to handle this?
- update `huggingface_hub` => I can take care of this
huggingface/huggingface_hub#3548
- update `hub-docs` => will happen automatically
I think it's fine to have breaking change for this. Moreover, specs /
docs are there more for information but are rarely enforced (expect in
TEI) so it shouldn't break anything client-side.1 parent e495f15 commit 7291a10
File tree
2 files changed
+2
-2
lines changed- packages/tasks/src/tasks/feature-extraction
- spec
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
0 commit comments