Add utf8 encoding to read_text to avoid Windows charmap crash (#2627)

tomaarsen · Wauplin · web-flow · commit 6ac7aef47613 · 2024-10-24T15:13:46.000+02:00
Co-authored-by: Lucain &lt;lucain@huggingface.co&gt;
diff --git a/src/huggingface_hub/hf_api.py b/src/huggingface_hub/hf_api.py
@@ -9165,7 +9165,7 @@ def _prepare_upload_folder_additions(
         # It's better to fail early than to fail after all the files have been hashed.
         if "README.md" in filtered_repo_objects:
             self._validate_yaml(
-                content=relpath_to_abspath["README.md"].read_text(),
+                content=relpath_to_abspath["README.md"].read_text(encoding="utf8"),
                 repo_type=repo_type,
                 token=token,
             )

Original file line number	Diff line number	Diff line change
`@@ -9165,7 +9165,7 @@ def _prepare_upload_folder_additions(`
`9165`	`9165`	`# It's better to fail early than to fail after all the files have been hashed.`
`9166`	`9166`	`if "README.md" in filtered_repo_objects:`
`9167`	`9167`	`self._validate_yaml(`
`9168`		`- content=relpath_to_abspath["README.md"].read_text(),`
	`9168`	`+ content=relpath_to_abspath["README.md"].read_text(encoding="utf8"),`
`9169`	`9169`	`repo_type=repo_type,`
`9170`	`9170`	`token=token,`
`9171`	`9171`	`)`