fix dataclass_with_extra

Author: Wauplin

src/huggingface_hub/inference/_generated/types/base.py

@@ -15,6 +15,7 @@
 
 import inspect
 import json
+import types
 from dataclasses import asdict, dataclass
 from typing import Any, TypeVar, Union, get_args
 
@@ -109,7 +110,9 @@ def parse_obj(cls: type[T], data: Union[bytes, str, list, dict]) -> Union[list[T
                     else:
                         expected_types = get_args(field_type)
                         for expected_type in expected_types:
-                            if getattr(expected_type, "_name", None) == "List":
+                            if (
+                                isinstance(expected_type, types.GenericAlias) and expected_type.__origin__ is list
+                            ) or getattr(expected_type, "_name", None) == "List":
                                 expected_type = get_args(expected_type)[
                                     0
                                 ]  # assume same type for all items in the list

tests/test_inference_types.py

@@ -1,6 +1,6 @@
 import inspect
 import json
-from typing import Optional, Union, get_args, get_origin
+from typing import List, Optional, Union, get_args, get_origin
 
 import pytest
 
@@ -18,7 +18,7 @@ class DummyType(BaseInferenceType):
 @dataclass_with_extra
 class DummyNestedType(BaseInferenceType):
     item: DummyType
-    items: list[DummyType]
+    items: List[DummyType]  # works both with List and list
     maybe_items: Optional[list[DummyType]] = None
 
 
@@ -97,6 +97,7 @@ def test_parse_nested_class():
 def test_all_fields_are_optional():
     # all fields are optional => silently accept None if server returns less data than expected
     instance = DummyNestedType.parse_obj({"maybe_items": [{}, DUMMY_AS_BYTES]})
+    assert isinstance(instance, DummyNestedType)
     assert instance.item is None
     assert instance.items is None
     assert len(instance.maybe_items) == 2