Skip to content

Commit b71441f

Browse files
Use default retry values in pagination (#3587)
* default retry for paginate * fix test
1 parent b7e5eac commit b71441f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/huggingface_hub/utils/_pagination.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def paginate(path: str, params: dict, headers: dict) -> Iterable:
4242
next_page = _get_next_page(r)
4343
while next_page is not None:
4444
logger.debug(f"Pagination detected. Requesting next page: {next_page}")
45-
r = http_backoff("GET", next_page, max_retries=20, retry_on_status_codes=429, headers=headers)
45+
r = http_backoff("GET", next_page, headers=headers)
4646
hf_raise_for_status(r)
4747
yield from r.json()
4848
next_page = _get_next_page(r)

tests/test_utils_pagination.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ def test_mocked_paginate(
5959
# Params not passed to next pages
6060
assert mock_get.call_args_list == [call("url", params=mock_params, headers=mock_headers)]
6161
assert mock_http_backoff.call_args_list == [
62-
call("GET", "url_p2", max_retries=20, retry_on_status_codes=429, headers=mock_headers),
63-
call("GET", "url_p3", max_retries=20, retry_on_status_codes=429, headers=mock_headers),
62+
call("GET", "url_p2", headers=mock_headers),
63+
call("GET", "url_p3", headers=mock_headers),
6464
]
6565

6666
def test_paginate_hf_api(self) -> None:

0 commit comments

Comments
 (0)